From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B954C46477 for ; Wed, 19 Jun 2019 07:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 549FC20823 for ; Wed, 19 Jun 2019 07:57:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FF6UGkhS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731275AbfFSH5K (ORCPT ); Wed, 19 Jun 2019 03:57:10 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41886 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731260AbfFSH5J (ORCPT ); Wed, 19 Jun 2019 03:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O9PX4Evk9ozBEp0+hOqHmr/yxryDhmYRUg7Ro6SH9UI=; b=FF6UGkhSjGG997X0qq7M0m91t IvKA3fuh/rw4lUT3Om9KPynfH6Rut/mKt18gfYyZaImUJL21usi2rVlgL9tdDF/mRcGySqtDij9ST thDDaue3m6Sj581sfYa2ysp4Z3Yx+SgRv2tytQCED29VZMaTi/jTifts1f7/VPRnSal8w0eHSG8Ia QGpMt3RZIbsD5e0AUq8Dv5y5Y5oKS6LWlQyzzp/b56JmFJRaj/+ByXEq9dNzS2/y66oM3E0pWmPDH T2xtsuH28GZqHrZlP9PvkbKEv8m+mjdSgOTrkjIKrgqowqeIf8T9HoF4GUcKDrtc3X3ZAeFge8y7u 8PUe00bAw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hdVSs-0006qJ-Bi; Wed, 19 Jun 2019 07:57:06 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BE75920A4E0CD; Wed, 19 Jun 2019 09:57:03 +0200 (CEST) Date: Wed, 19 Jun 2019 09:57:03 +0200 From: Peter Zijlstra To: Arnd Bergmann Cc: Andrey Ryabinin , Andrew Morton , Josh Poimboeuf , Linux Kernel Mailing List , "# 3.4.x" Subject: Re: [PATCH] ubsan: mark ubsan_type_mismatch_common inline Message-ID: <20190619075703.GK3419@hirez.programming.kicks-ass.net> References: <20190617123109.667090-1-arnd@arndb.de> <20190617140210.GB3436@hirez.programming.kicks-ass.net> <20190618135911.GR3436@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 05:06:39PM +0200, Arnd Bergmann wrote: > On Tue, Jun 18, 2019 at 3:59 PM Peter Zijlstra wrote: > > On Tue, Jun 18, 2019 at 04:27:45PM +0300, Andrey Ryabinin wrote: > > > On 6/18/19 3:56 PM, Arnd Bergmann wrote: > > > > On Mon, Jun 17, 2019 at 4:02 PM Peter Zijlstra wrote: > > > > I guess this: > > > ccflags-y += $(DISABLE_STACKLEAK_PLUGIN) > > > > Or more specifically this, I guess: > > > > CFLAGS_ubsan.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector) $(DISABLE_STACKLEAK_PLUGIN) > > > > we'd not want to exclude all of lib/ from stackleak I figure. > > > > Of these two options, I think I prefer the latter, because a smaller > > whitelist is a better whitelist and since we already disable > > stack protector, it is only consistent to also disable stack leak. > > Ok, sounds good to me. Can you send that upstream then, or should > I write it up as a proper patch? If you could verify it actually works that would be great, I haven't tried to construct a failing .config yet.