From: Peter Zijlstra <peterz@infradead.org>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Jessica Yu <jeyu@kernel.org>,
linux-kernel@vger.kernel.org, jpoimboe@redhat.com,
jikos@kernel.org, pmladek@suse.com, rostedt@goodmis.org,
ast@kernel.org, daniel@iogearbox.net
Subject: Re: [RFC][PATCH] module: Propagate MODULE_STATE_COMING notifier errors
Date: Wed, 19 Jun 2019 13:23:50 +0200 [thread overview]
Message-ID: <20190619112350.GN3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.LSU.2.21.1906191251380.23337@pobox.suse.cz>
On Wed, Jun 19, 2019 at 01:12:12PM +0200, Miroslav Benes wrote:
> > @@ -3780,7 +3781,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
> >
> > err = prepare_coming_module(mod);
> > if (err)
> > - goto bug_cleanup;
> > + goto coming_cleanup;
>
> Not good. klp_module_going() is not prepared to be called without
> klp_module_coming() succeeding. "Funny" things might happen.
Bah, I did look at that but failed to spot it :/
> So it calls for more fine-grained error handling.
Another approach that I considered was trying to re-iterate the notifier
list up until the point we got, but that was fairly non-trivial and
needed changes to the notifier crud itself.
I'll try again.
next prev parent reply other threads:[~2019-06-19 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 9:03 Peter Zijlstra
2019-06-17 23:18 ` Steven Rostedt
2019-06-19 11:12 ` Miroslav Benes
2019-06-19 11:23 ` Peter Zijlstra [this message]
2019-06-19 11:33 ` Peter Zijlstra
2019-06-19 11:35 ` Peter Zijlstra
2019-06-19 12:01 ` Peter Zijlstra
2019-06-21 16:31 ` Jessica Yu
2019-06-19 11:25 ` Peter Zijlstra
2019-06-19 11:56 ` Petr Mladek
2019-06-21 16:18 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619112350.GN3419@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome