From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mei: no need to check return value of debugfs_create functions
Date: Wed, 19 Jun 2019 15:00:51 +0200 [thread overview]
Message-ID: <20190619130051.GC27090@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9DC4B6C4@hasmsx108.ger.corp.intel.com>
On Wed, Jun 19, 2019 at 08:25:58AM +0000, Winkler, Tomas wrote:
> >
> > When calling debugfs functions, there is no need to ever check the return
> > value. The function can work or not, but the code logic should never do
> > something different based on this.
>
> Maybe need to mention that API has changed in patch ' ff9fb72bc07705c00795ca48631f7fffe24d2c6b' in 5.0
> and create_dir() doesn't return NULL but ERR_PTR() and proper checking is done inside the debugfs functions.
> Not sure how critical is that but, but this should go probably to stable 5.0+ as well.
It's not critical at all, the odds of an error ever returning, or NULL,
from debugfs before is just as rare as it is today :)
> Ack otherwise.
great, thanks for reviewing it.
greg k-h
prev parent reply other threads:[~2019-06-19 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:33 [PATCH] " Greg Kroah-Hartman
2019-06-11 18:34 ` Greg Kroah-Hartman
2019-06-11 18:38 ` [PATCH v2] " Greg Kroah-Hartman
2019-06-19 8:25 ` Winkler, Tomas
2019-06-19 13:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619130051.GC27090@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome