mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Smelkov <kirr@nexedi.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Bjorn Helgaas <helgaas@kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kbuild-all@01.org>
Subject: Re: [PATCH] pci/switchtec: fix stream_open.cocci warnings (fwd)
Date: Wed, 19 Jun 2019 16:27:53 +0000	[thread overview]
Message-ID: <20190619162713.GA19859@deco.navytux.spb.ru> (raw)
In-Reply-To: <alpine.DEB.2.20.1906191227430.3726@hadrien>

Hi Julia, everyone.

On Wed, Jun 19, 2019 at 12:28:47PM +0200, Julia Lawall wrote:
> Hi,
> 
> Can you forward this patch to the people below if you think it is
> appropriate?

Yes, this patch is appropriate. It was actually part of
git.kernel.org/linus/c5bf68fe0c86 . It should be safe, (and desirable as
it removes a chance for deadlock) to apply it. 

Sebastian, Kurt, Logan, Bjorn, please consider picking it up.

> Could I tell the kbuild people to add you to the CC list for
> this semantic patch?

Yes, sure. Please feel free to add me to CC list for stream_open.cocci
related patches.

Kirill


> thanks,
> julia
> 
> ---------- Forwarded message ----------
> Date: Wed, 19 Jun 2019 18:23:18 +0800
> From: kbuild test robot <lkp@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: [PATCH] pci/switchtec: fix stream_open.cocci warnings
> 
> CC: kbuild-all@01.org
> TO: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> CC: Kurt Schwemmer <kurt.schwemmer@microsemi.com>
> CC: Logan Gunthorpe <logang@deltatee.com>
> CC: Bjorn Helgaas <helgaas@kernel.org>
> CC: linux-pci@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> 
> From: kbuild test robot <lkp@intel.com>
> 
> drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
> 
> Generated by: scripts/coccinelle/api/stream_open.cocci
> 
> Fixes: a3a1e895d4fa ("pci/switchtec: Don't use completion's wait queue")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.0.y-rt-rebase
> head:   31cc76d5590f5e60c2f26f029e40bc7d0441d93f
> commit: a3a1e895d4fa0508e11ac9107ace883a5b2a4d3b [171/305] pci/switchtec: Don't use completion's wait queue
> :::::: branch date: 6 days ago
> :::::: commit date: 6 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  switchtec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -392,7 +392,7 @@ static int switchtec_dev_open(struct ino
>  		return PTR_ERR(stuser);
> 
>  	filp->private_data = stuser;
> -	nonseekable_open(inode, filp);
> +	stream_open(inode, filp);
> 
>  	dev_dbg(&stdev->dev, "%s: %p\n", __func__, stuser);
>

       reply	other threads:[~2019-06-19 16:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.DEB.2.20.1906191227430.3726@hadrien>
2019-06-19 16:27 ` Kirill Smelkov [this message]
2019-06-19 19:47   ` Logan Gunthorpe
2019-06-19 20:19   ` Bjorn Helgaas
2019-06-19 20:21     ` Julia Lawall
2019-06-20  7:01     ` kirr
2019-06-21 16:42       ` Sebastian Andrzej Siewior
2019-04-13 16:50 Julia Lawall
2019-04-13 16:56 ` Logan Gunthorpe
2019-04-13 17:01 ` Kirill Smelkov
2019-04-15 14:38   ` Sebastian Andrzej Siewior
2019-04-15 14:55     ` Kirill Smelkov
2019-04-15 15:20       ` Sebastian Andrzej Siewior
2019-04-15 15:41         ` Kirill Smelkov
2019-04-17 21:54 ` Bjorn Helgaas
2019-04-18  5:31   ` Julia Lawall
2019-04-18 10:38     ` Kirill Smelkov
2019-04-18 12:37       ` Bjorn Helgaas
2019-04-18 14:42         ` Kirill Smelkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619162713.GA19859@deco.navytux.spb.ru \
    --to=kirr@nexedi.com \
    --cc=bigeasy@linutronix.de \
    --cc=helgaas@kernel.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kbuild-all@01.org \
    --cc=kurt.schwemmer@microsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®