From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F07C31E5B for ; Wed, 19 Jun 2019 16:45:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57376217F4 for ; Wed, 19 Jun 2019 16:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560962745; bh=5B3ZAjA7gOsgPJfhSPrsXHeb6ZPgy7neIaABFDQJVWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pQd0omZPxJ58rheaZQl3LRsXXcbOIPV4xY4hQAw18KoUfWcbSoBGNdBwDZYAHMO2n YOuSUxSrR/vWpKNzjv0jWUR05m3xB3gwwhDwdzI/mMWHlx2fsqd2+L4qsvoeyVYEid hUJ9AvtBSuXx3bvaWywbcl3S9l9LWutg0SCll1MI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730206AbfFSQpn (ORCPT ); Wed, 19 Jun 2019 12:45:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:42180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730110AbfFSQpg (ORCPT ); Wed, 19 Jun 2019 12:45:36 -0400 Received: from tleilax.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C36921855; Wed, 19 Jun 2019 16:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560962735; bh=5B3ZAjA7gOsgPJfhSPrsXHeb6ZPgy7neIaABFDQJVWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTSiijTkGBlVwEaqv72N9A3Oa68AwSIHmtMvOChlC17s2KSX3VzwQ5nxwXVRlGk95 hwnkWducDb9hcELH5CuiV/tqoSB5si7SR95y9YLo3Ppi2PFTUhj7DIqBNHerw8SGUK LdFiMEV1MkWwbFBhpKTgXYdICqZT8ohVCXULN2Ak= From: Jeff Layton To: linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, zyan@redhat.com, sage@redhat.com, agruenba@redhat.com, joe@perches.com, pmladek@suse.com, rostedt@goodmis.org, geert+renesas@glider.be, andriy.shevchenko@linux.intel.com Subject: [PATCH v2 3/3] ceph: return -ERANGE if virtual xattr value didn't fit in buffer Date: Wed, 19 Jun 2019 12:45:28 -0400 Message-Id: <20190619164528.31958-4-jlayton@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190619164528.31958-1-jlayton@kernel.org> References: <20190619164528.31958-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The getxattr manpage states that we should return ERANGE if the destination buffer size is too small to hold the value. Signed-off-by: Jeff Layton --- fs/ceph/xattr.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index a1cd9613be98..e3246c27f2da 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c @@ -805,8 +805,11 @@ ssize_t __ceph_getxattr(struct inode *inode, const char *name, void *value, if (err) return err; err = -ENODATA; - if (!(vxattr->exists_cb && !vxattr->exists_cb(ci))) + if (!(vxattr->exists_cb && !vxattr->exists_cb(ci))) { err = vxattr->getxattr_cb(ci, value, size); + if (size && size < err) + err = -ERANGE; + } return err; } -- 2.21.0