From: Matthias Kaehlcke <mka@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Tom Roeder <tmroeder@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
LKML <linux-kernel@vger.kernel.org>,
Raul E Rangel <rrangel@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Ryan Case <ryandcase@chromium.org>, Yu Liu <yudiliu@google.com>,
Doug Anderson <dianders@google.com>
Subject: Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory
Date: Thu, 20 Jun 2019 13:54:06 -0700 [thread overview]
Message-ID: <20190620205406.GY137143@google.com> (raw)
In-Reply-To: <CAKwvOdn-o9UszRW+MQ9Z0Ds9B2wSVBWUsPBPSF0S2DYxVFYpqA@mail.gmail.com>
On Thu, Jun 20, 2019 at 12:53:22PM -0700, Nick Desaulniers wrote:
> On Thu, Jun 20, 2019 at 11:45 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > gen_compile_command.py currently assumes that the .cmd files and the
> > source code live in the same directory, which is not the case when
> > a separate KBUILD_OUTPUT directory is used.
>
> Great point; android builds the kernel outside of the source dir
> (`make O=/non-source/path ...`). Thanks for the patch! BTW if CrOS is
> doing cool stuff with compile_commands.json; I'd like to know!
> Particularly; I'm curious if it's possible to generate Ninja build
> files from compile_commands.json; I do miss Doug's Kbuild caching
> patches' speedup.
> Acked-by: Nick Desaulniers <ndesaulniers@google.com>
At this point Chrome OS doesn't do anything with compile_commands.json
for the kernel. I was just toying around a bit after a presentation
from Tom Hughes about IDE integration and encountered this limitation.
prev parent reply other threads:[~2019-06-20 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 18:45 Matthias Kaehlcke
2019-06-20 19:23 ` Tom Roeder
2019-06-20 20:47 ` Matthias Kaehlcke
2019-06-20 19:53 ` Nick Desaulniers
2019-06-20 20:13 ` Doug Anderson
2019-06-20 20:25 ` Nick Desaulniers
2019-06-20 20:38 ` Nathan Chancellor
2019-06-20 20:57 ` Doug Anderson
2019-06-20 20:54 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620205406.GY137143@google.com \
--to=mka@chromium.org \
--cc=dianders@chromium.org \
--cc=dianders@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=rrangel@chromium.org \
--cc=ryandcase@chromium.org \
--cc=tmroeder@google.com \
--cc=tomhughes@chromium.org \
--cc=yamada.masahiro@socionext.com \
--cc=yudiliu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome