From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [GIT PULL 2/4] intel_th: msu: Remove set but not used variable 'last'
Date: Fri, 21 Jun 2019 19:19:28 +0300 [thread overview]
Message-ID: <20190621161930.60785-3-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <20190621161930.60785-1-alexander.shishkin@linux.intel.com>
From: YueHaibing <yuehaibing@huawei.com>
Commit aad14ad3cf3a ("intel_th: msu: Add current window tracking") added
the following gcc warning:
> drivers/hwtracing/intel_th/msu.c: In function msc_win_switch:
> drivers/hwtracing/intel_th/msu.c:1389:21: warning: variable last set but
> not used [-Wunused-but-set-variable]
Fix it by removing the variable.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Fixes: aad14ad3cf3a ("intel_th: msu: Add current window tracking")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
drivers/hwtracing/intel_th/msu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
index 8c568b5c8920..6bfce03c6489 100644
--- a/drivers/hwtracing/intel_th/msu.c
+++ b/drivers/hwtracing/intel_th/msu.c
@@ -1400,10 +1400,9 @@ static int intel_th_msc_init(struct msc *msc)
static void msc_win_switch(struct msc *msc)
{
- struct msc_window *last, *first;
+ struct msc_window *first;
first = list_first_entry(&msc->win_list, struct msc_window, entry);
- last = list_last_entry(&msc->win_list, struct msc_window, entry);
if (msc_is_last_win(msc->cur_win))
msc->cur_win = first;
--
2.20.1
next prev parent reply other threads:[~2019-06-21 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 16:19 [GIT PULL 0/4] intel_th: Fixes for v5.2 Alexander Shishkin
2019-06-21 16:19 ` [GIT PULL 1/4] intel_th: msu: Fix unused variable warning on arm64 platform Alexander Shishkin
2019-06-21 16:19 ` Alexander Shishkin [this message]
2019-06-21 16:19 ` [GIT PULL 3/4] intel_th: msu: Fix single mode with disabled IOMMU Alexander Shishkin
2019-07-03 15:36 ` Greg Kroah-Hartman
2019-06-21 16:19 ` [GIT PULL 4/4] intel_th: pci: Add Ice Lake NNPI support Alexander Shishkin
2019-07-03 15:26 ` [GIT PULL 0/4] intel_th: Fixes for v5.2 Alexander Shishkin
2019-07-03 15:34 ` Greg Kroah-Hartman
2019-07-03 15:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621161930.60785-3-alexander.shishkin@linux.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®