From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C44C43613 for ; Sat, 22 Jun 2019 00:56:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B67CB2075E for ; Sat, 22 Jun 2019 00:56:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbfFVA4N (ORCPT ); Fri, 21 Jun 2019 20:56:13 -0400 Received: from mga04.intel.com ([192.55.52.120]:31542 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbfFVA4L (ORCPT ); Fri, 21 Jun 2019 20:56:11 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2019 17:56:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,402,1557212400"; d="scan'208";a="335995515" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 21 Jun 2019 17:56:09 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1heUK9-000Eoq-1b; Sat, 22 Jun 2019 08:56:09 +0800 Date: Sat, 22 Jun 2019 08:55:47 +0800 From: kbuild test robot To: Enric Balletbo i Serra Cc: kbuild-all@01.org, Ezequiel Garcia , Nick Crews , Benson Leung , linux-kernel@vger.kernel.org Subject: [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings Message-ID: <20190622005547.GA65190@lkp-kbuild08> References: <201906220821.144PfQAY%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201906220821.144PfQAY%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime") Signed-off-by: kbuild test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next head: 9eecd07b34507de9d6a9c264d13d30e1ee5fabe8 commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime Please take the patch only if it's a positive warning. Thanks! event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/chrome/wilco_ec/event.c +++ b/drivers/platform/chrome/wilco_ec/event.c @@ -267,7 +267,7 @@ static int event_open(struct inode *inod /* Increase refcount on device so dev_data is not freed */ get_device(&dev_data->dev); - nonseekable_open(inode, filp); + stream_open(inode, filp); filp->private_data = dev_data; return 0;