From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C17DC4646B for ; Sat, 22 Jun 2019 16:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 481852070B for ; Sat, 22 Jun 2019 16:27:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561220836; bh=T7HU5KECI7qFIbgaAUEi7g+0ukBFtxhyu6h2wwfuV1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SbkG6r8crz8xk6OcQyiv62Oc0OsAHsmCswNiDUe/Z1n71VwUcKDBPL6M4kgHcVNQl YMhuyTkkqkW0dKnKV4p6j0IAdFa+l0WcVM3rH7SXV2HCU6L1h19EAC+M4Xy5Wi5T+r uG9RIdJ/GRxAK36bX8cQQkdLN+ZHswk2VFhPQMNQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbfFVQ1P (ORCPT ); Sat, 22 Jun 2019 12:27:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:52884 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726276AbfFVQ1P (ORCPT ); Sat, 22 Jun 2019 12:27:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7A142AE56; Sat, 22 Jun 2019 16:27:13 +0000 (UTC) Date: Sat, 22 Jun 2019 18:27:10 +0200 From: Michal Hocko To: Ajay Kaher Cc: Greg KH , "Stable tree ," , "Jason Gunthorpe ," , "linux-mm@kvack.org, LKML ," , "Andrea Arcangeli ," , "Jann Horn ," , "Oleg Nesterov ," , "Peter Xu ," , "Mike Rapoport ," , "Andrew Morton ," , "Linus Torvalds ," , Joel Fernandes Subject: Re: [PATCH stable-4.4 v3] coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping Message-ID: <20190622162710.GA15805@dhcp22.suse.cz> References: <66C05D07-4075-400D-832C-C82120C93922@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66C05D07-4075-400D-832C-C82120C93922@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 22-06-19 06:30:37, Ajay Kaher wrote: > > > On Mon, Jun 17, 2019 at 08:58:24AM +0200, Michal Hocko wrote: > > > From: Andrea Arcangeli > > > > > > Upstream 04f5866e41fb70690e28397487d8bd8eea7d712a commit. > > > > > > Signed-off-by: Michal Hocko > > > --- > > > drivers/android/binder.c | 6 ++++++ > > > drivers/infiniband/hw/mlx4/main.c | 3 +++ > > > fs/proc/task_mmu.c | 18 ++++++++++++++++++ > > > fs/userfaultfd.c | 10 ++++++++-- > > > include/linux/mm.h | 21 +++++++++++++++++++++ > > > mm/mmap.c | 7 ++++++- > > > 6 files changed, 62 insertions(+), 3 deletions(-) > > > > I've queued this up now, as it looks like everyone agrees with it. What > > about a 4.9.y backport? > > Greg, it's here please review. > https://lore.kernel.org/stable/1561208539-29682-1-git-send-email-akaher@vmware.com/T/#m53eaf6e687cb27e46395173aa74a85c2ccb5c190 > > Michal, patched for binder code Thanks, would you like to suggest > if mmget_still_valid check require anywhere for khugepaged code. khugepaged patch has gone its own way. See 59ea6d06cfa9 ("coredump: fix race condition between collapse_huge_page() and core dumping") -- Michal Hocko SUSE Labs