From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF96C43613 for ; Sun, 23 Jun 2019 19:27:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7687F206BA for ; Sun, 23 Jun 2019 19:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561318021; bh=Qk84AQXyLsM0Q715iByu0Urs776YIzdFYFvfNBzaHSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fPJKhqhQN1+lt/OMKEokEAKt0NqIjxHIPVgFQztCs+9q9AYD6rQIMjeXxN+BszxOS xPk21EiFzK4EBiVwBKOjPvznFN07Gy9PQVgrTZV/HC/21a5bkzZItu9VA5YDS5Jn0+ dEvN4auYtiJ6lp+PYxI1HsDls4LUlHStb7TtzEDI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfFWT07 (ORCPT ); Sun, 23 Jun 2019 15:26:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbfFWT06 (ORCPT ); Sun, 23 Jun 2019 15:26:58 -0400 Received: from localhost (unknown [107.242.116.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77FBA20645; Sun, 23 Jun 2019 19:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561318017; bh=Qk84AQXyLsM0Q715iByu0Urs776YIzdFYFvfNBzaHSQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nvyWq0tGWxoBQWi1U8yw0GrSEkKGf9Ep8x5Mzd/lvnjUaj/tNarFybHick6q4z6r3 CSp9qsNHB+WS2E64s8Df+Zepy2dC1lYlLwV7iqvfMZooIdAwElf2I9lw7JjCE1l//A c+QaMlPr6TDTUPIbb1suKEJ196kigSoZ4+ARTdiI= Date: Sun, 23 Jun 2019 15:26:52 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chengguang Xu , Wu Hao , Alan Tull , linux-fpga@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.1 17/59] fpga: dfl: expand minor range when registering chrdev region Message-ID: <20190623192652.GM2226@sasha-vm> References: <20190614202843.26941-1-sashal@kernel.org> <20190614202843.26941-17-sashal@kernel.org> <20190615054806.GB23883@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190615054806.GB23883@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 15, 2019 at 07:48:06AM +0200, Greg Kroah-Hartman wrote: >On Fri, Jun 14, 2019 at 04:28:01PM -0400, Sasha Levin wrote: >> From: Chengguang Xu >> >> [ Upstream commit de9a7f6f5f1967d275311cca9163b4a3ffe9b0ae ] >> >> Actually, total amount of available minor number >> for a single major is MINORMASK + 1. So expand >> minor range when registering chrdev region. >> >> Signed-off-by: Chengguang Xu >> Acked-by: Wu Hao >> Acked-by: Alan Tull >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> drivers/fpga/dfl.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c >> index c25217cde5ca..4b66aaa32b5a 100644 >> --- a/drivers/fpga/dfl.c >> +++ b/drivers/fpga/dfl.c >> @@ -322,7 +322,7 @@ static void dfl_chardev_uinit(void) >> for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) >> if (MAJOR(dfl_chrdevs[i].devt)) { >> unregister_chrdev_region(dfl_chrdevs[i].devt, >> - MINORMASK); >> + MINORMASK + 1); >> dfl_chrdevs[i].devt = MKDEV(0, 0); >> } >> } >> @@ -332,8 +332,8 @@ static int dfl_chardev_init(void) >> int i, ret; >> >> for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) { >> - ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, MINORMASK, >> - dfl_chrdevs[i].name); >> + ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, >> + MINORMASK + 1, dfl_chrdevs[i].name); >> if (ret) >> goto exit; >> } > >Not a bugfix, so not needed for stable kernels, thanks. Dropped, thanks! -- Thanks, Sasha