From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Brian Vazquez <brianvv.kernel@gmail.com>
Cc: Brian Vazquez <brianvv@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Stanislav Fomichev <sdf@google.com>,
Willem de Bruijn <willemb@google.com>,
Petar Penkov <ppenkov@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [RFC PATCH 2/6] bpf: add BPF_MAP_DUMP command to access more than one entry per call
Date: Mon, 24 Jun 2019 17:14:16 -0700 [thread overview]
Message-ID: <20190624171416.2a39f4c7@cakuba.netronome.com> (raw)
In-Reply-To: <CABCgpaUhHmLaWUg-x_X+yYD6pnoAcMLw9jr1BPnv5vrM-NYmqQ@mail.gmail.com>
On Mon, 24 Jun 2019 16:35:05 -0700, Brian Vazquez wrote:
> On Mon, Jun 24, 2019 at 3:46 PM Jakub Kicinski wrote:
> > On Fri, 21 Jun 2019 16:16:46 -0700, Brian Vazquez wrote:
> > > @@ -385,6 +386,14 @@ union bpf_attr {
> > > __u64 flags;
> > > };
> > >
> > > + struct { /* struct used by BPF_MAP_DUMP command */
> > > + __u32 map_fd;
> >
> > There is a hole here, perhaps flags don't have to be 64 bit?
> The command implementation is wrapping BPF_MAP_*_ELEM commands, I
> would expect this one to handle the same flags which are 64 bit.
> Note that there's a hole in the anonymous structure used by the other
> commands too:
> struct { /* anonymous struct used by BPF_MAP_*_ELEM commands */
> __u32 map_fd;
> __aligned_u64 key;
> union {
> __aligned_u64 value;
> __aligned_u64 next_key;
> };
> __u64 flags;
> };
Ah, okay.
next prev parent reply other threads:[~2019-06-25 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 23:16 [RFC PATCH 0/6] bpf: add BPF_MAP_DUMP command to access more Brian Vazquez
2019-06-21 23:16 ` [RFC PATCH 1/6] bpf: add bpf_map_value_size and bp_map_copy_value helper functions Brian Vazquez
2019-06-21 23:16 ` [RFC PATCH 2/6] bpf: add BPF_MAP_DUMP command to access more than one entry per call Brian Vazquez
2019-06-24 22:45 ` Jakub Kicinski
2019-06-24 23:35 ` Brian Vazquez
2019-06-25 0:14 ` Jakub Kicinski [this message]
2019-06-21 23:16 ` [RFC PATCH 3/6] bpf: keep bpf.h in sync with tools/ Brian Vazquez
2019-06-21 23:16 ` [RFC PATCH 4/6] libbpf: support BPF_MAP_DUMP command Brian Vazquez
2019-06-21 23:16 ` [RFC PATCH 5/6] selftests/bpf: test BPF_MAP_DUMP command on a bpf hashmap Brian Vazquez
2019-06-21 23:16 ` [RFC PATCH 6/6] selftests/bpf: add test to measure performance of BPF_MAP_DUMP Brian Vazquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624171416.2a39f4c7@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brianvv.kernel@gmail.com \
--cc=brianvv@google.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=sdf@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®