From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C43C4646C for ; Tue, 25 Jun 2019 03:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20BE420665 for ; Tue, 25 Jun 2019 03:08:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=etsukata-com.20150623.gappssmtp.com header.i=@etsukata-com.20150623.gappssmtp.com header.b="VOqJRbhX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbfFYDI2 (ORCPT ); Mon, 24 Jun 2019 23:08:28 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40685 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfFYDI2 (ORCPT ); Mon, 24 Jun 2019 23:08:28 -0400 Received: by mail-pg1-f196.google.com with SMTP id w10so8153591pgj.7 for ; Mon, 24 Jun 2019 20:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsukata-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zExVfQYPlu8nT0CJtzuqIZxBlVwcNRcoQAaprYs9bF4=; b=VOqJRbhXB9uGMJ5ABIUJOCPwsR7f7mwphTcc1odyIt5pF1uiLR9cktL7WbqNCdsSKV +KeiUUxAtVgdPBt2NqOawG17pj58pMp1cY7lUdh8wRfcsXgdcPyVK8pNzk33Or5Bawzk EPQKYq0fkFyLz5LoXnKg88p0uGdD0LItDbqf5zxqNuUSScOBHWVNlIeR5jhczOjeqBOe DNUte19yK728oUrAiM2j1Fkt799o3maY2vWPKG7nOV86fmGaQyWj3jwJACix+sdn8f18 xRVbT1N1RxT4hruCq/RzBMPKYdR3wzgnjuji/oWQOtS9RmAM9SPOBC2PQo5mfsbKwtNE hILA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zExVfQYPlu8nT0CJtzuqIZxBlVwcNRcoQAaprYs9bF4=; b=pgih4GCHl0nDfVfzbZU3mzFi4kB2JgxRDstUfSe8L/6F0SI+kGxPsR0U7ZMpymK7w4 h4F/B4P9D2JRgreeHiT/xR8VlM9xs/8NgfvwfsvkDx8VOzkttIJGMtvjs2eWPSXthfwC rzRFZ89gEEavoz1kyZwCDRCQ1TZ179XAZcfnvevjkUCdB5vjyKyHbYr2qJFO030svWpa 2EQpKV18qATuz4D6ArKsQ5nwJby2jJ+aOcNJF9Jt14N5l34IQMGZr4OcsbWtNvdRA/MZ dQ7aBcnqkJkEWhZq6MmYDNwERiuFwnONVzTO3/9VaZ9NzS1qIK2eMsM7wSFpdDodgjP7 dLGw== X-Gm-Message-State: APjAAAXCQQelfHCwa2wxK+b1AbQ+ajpR47FVPuybD11DgNhF7SA+q6H9 RaKvxQPIbMZVFScXP3BkIW7TSA== X-Google-Smtp-Source: APXvYqxgTwHx16vcj9gEYkBi/DiZVzjaUo2Ng8a8/VD9S52b0KE5xzakjnq2U19lX2AaU/+AUC8j0w== X-Received: by 2002:a63:f648:: with SMTP id u8mr36137024pgj.132.1561432107914; Mon, 24 Jun 2019 20:08:27 -0700 (PDT) Received: from localhost.localdomain (p2517222-ipngn21701marunouchi.tokyo.ocn.ne.jp. [118.7.246.222]) by smtp.gmail.com with ESMTPSA id d4sm708016pju.31.2019.06.24.20.08.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 20:08:27 -0700 (PDT) From: Eiichi Tsukata To: gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Eiichi Tsukata Subject: [PATCH 2/2] net/ipv6: Fix misuse of proc_dointvec "skip_notify_on_dev_down" Date: Tue, 25 Jun 2019 12:08:01 +0900 Message-Id: <20190625030801.24538-2-devel@etsukata.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190625030801.24538-1-devel@etsukata.com> References: <20190625030801.24538-1-devel@etsukata.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org /proc/sys/net/ipv6/route/skip_notify_on_dev_down assumes given value to be 0 or 1. Use proc_dointvec_minmax instead of proc_dointvec. Fixes: 7c6bb7d2faaf ("net/ipv6: Add knob to skip DELROUTE message ondevice down") Signed-off-by: Eiichi Tsukata --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 11ad62effd56..aade636c6be6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5281,7 +5281,7 @@ static struct ctl_table ipv6_route_table_template[] = { .data = &init_net.ipv6.sysctl.skip_notify_on_dev_down, .maxlen = sizeof(int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_dointvec_minmax, .extra1 = &zero, .extra2 = &one, }, -- 2.21.0