mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Parth Shah <parth@linux.ibm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, dietmar.eggemann@arm.com,
	patrick.bellasi@arm.com
Subject: [RFCv3 1/8] sched/core: Add manual jitter classification using sched_setattr syscall
Date: Tue, 25 Jun 2019 10:07:19 +0530	[thread overview]
Message-ID: <20190625043726.21490-2-parth@linux.ibm.com> (raw)
In-Reply-To: <20190625043726.21490-1-parth@linux.ibm.com>

Jitter tasks are short/bursty tasks,typically performing some housekeeping
and are less important in the overall scheme of things. In this patch we
provide a mechanism based on Patrick Bellasi's UCLAMP framework to classify
jitter tasks"

We define jitter tasks as those whose util.max in the UCLAMP framework is
the least (=0). This also provides benefit of giving the least frequency to
those jitter tasks, which is useful if all jitters are packed onto a
separate core."

UCLAMP already provides a way to set util.max for a task by using a syscall
interface. This patch uses the `sched_setattr` syscall to set
sched_util_max attribute of the task which is used to classify the task as
jitter.

Use Case with turbo_bench.c
===================
```
i=8;
./turbo_bench -t 30 -h $i -n $((2*i)) -j
```
This spawns 2*i total threads: of which i-CPU bound and i-jitter threads.

Signed-off-by: Parth Shah <parth@linux.ibm.com>
---
 include/linux/sched.h | 6 ++++++
 kernel/sched/core.c   | 9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index e2d80e6a187d..2bd9f75a3abb 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -696,6 +696,12 @@ struct task_struct {
 	struct uclamp_se		uclamp_req[UCLAMP_CNT];
 	/* Effective clamp values used for a scheduling entity */
 	struct uclamp_se		uclamp[UCLAMP_CNT];
+	/*
+	 * Tag the task as jitter.
+	 * 0 = regular. Follows regular CFS policy for task placement.
+	 * 1 = Jitter tasks. Should be packed to reduce active core count.
+	 */
+	unsigned int			is_jitter;
 #endif
 
 #ifdef CONFIG_PREEMPT_NOTIFIERS
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index ab0aa319fe60..19c7204d6351 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1189,6 +1189,15 @@ static void __setscheduler_uclamp(struct task_struct *p,
 	if (attr->sched_flags & SCHED_FLAG_UTIL_CLAMP_MAX) {
 		uclamp_se_set(&p->uclamp_req[UCLAMP_MAX],
 			      attr->sched_util_max, true);
+
+		/*
+		 * Set task to jitter class if Max util is clamped to the least
+		 * possible value
+		 */
+		if (p->uclamp_req[UCLAMP_MAX].bucket_id == 0 && !p->is_jitter)
+			p->is_jitter = 1;
+		else if (p->is_jitter)
+			p->is_jitter = 0;
 	}
 }
 
-- 
2.17.1


  reply	other threads:[~2019-06-25  4:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  4:37 [RFCv3 0/8] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations Parth Shah
2019-06-25  4:37 ` Parth Shah [this message]
2019-06-25  4:37 ` [RFCv3 2/8] sched: Introduce switch to enable TurboSched mode Parth Shah
2019-06-25  4:37 ` [RFCv3 3/8] sched/core: Update turbo_sched count only when required Parth Shah
2019-06-25  4:37 ` [RFCv3 4/8] sched/fair: Define core capacity to limit task packing Parth Shah
2019-06-25  4:37 ` [RFCv3 5/8] powerpc: Define Core Capacity for POWER systems Parth Shah
2019-06-25  4:37 ` [RFCv3 6/8] sched/fair: Tune task wake-up logic to pack jitter tasks Parth Shah
2019-06-25  4:37 ` [RFCv3 7/8] sched/fair: Bound non idle core search within LLC domain Parth Shah
2019-06-25  4:37 ` [RFCv3 8/8] powerpc: Set turbo domain to NUMA node for task packing Parth Shah
2019-06-28 13:14 ` [RFCv3 0/8] TurboSched: A scheduler for sustaining Turbo Frequencies for longer durations Patrick Bellasi
2019-06-28 16:42   ` Parth Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625043726.21490-2-parth@linux.ibm.com \
    --to=parth@linux.ibm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=patrick.bellasi@arm.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome