From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8663FC4646B for ; Wed, 26 Jun 2019 06:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EFE72085A for ; Wed, 26 Jun 2019 06:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561529500; bh=xM0h0XhTRFJSlg6RglEf/KrmnyLUzN9SwS64n/3FwgM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ay/baGuveg9VKtFhV501OEkiI3xF7zXBfOZzB/iroD6apMIzSZFH9Ku9gXtlNtoxG W0H3gG3T0gNT5QJM5HcwrUXST1IMRIiaynvjeM4nvXWtef1vAwAmDKFrJLZQssqONE cQOt/miOCVW0/V1JNOYfC554sOR++gFOGX0iAPwo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726618AbfFZGLj (ORCPT ); Wed, 26 Jun 2019 02:11:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:57120 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725379AbfFZGLi (ORCPT ); Wed, 26 Jun 2019 02:11:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 96E90AF25; Wed, 26 Jun 2019 06:11:36 +0000 (UTC) Date: Wed, 26 Jun 2019 08:11:34 +0200 From: Michal Hocko To: Hoan Tran OS Cc: Catalin Marinas , Will Deacon , Andrew Morton , Vlastimil Babka , Oscar Salvador , Pavel Tatashin , Mike Rapoport , Alexander Duyck , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , "David S . Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "open list:MEMORY MANAGEMENT" , "linux-arm-kernel@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Open Source Submission Subject: Re: [PATCH 1/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-ID: <20190626061134.GD17798@dhcp22.suse.cz> References: <1561501810-25163-1-git-send-email-Hoan@os.amperecomputing.com> <1561501810-25163-2-git-send-email-Hoan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1561501810-25163-2-git-send-email-Hoan@os.amperecomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 25-06-19 22:30:24, Hoan Tran OS wrote: > This patch enables CONFIG_NODES_SPAN_OTHER_NODES by default > for NUMA. As some NUMA nodes have memory ranges that span other > nodes. Even though a pfn is valid and between a node's start and > end pfns, it may not reside on that node. Please describe the problem more thoroughly. What is the layout, what doesn't work with the default configuration and why do we need this particular fix rather than enabling of the config option for the specific HW. > > Signed-off-by: Hoan Tran > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d66bc8a..6335505 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1413,7 +1413,7 @@ int __meminit early_pfn_to_nid(unsigned long pfn) > } > #endif > > -#ifdef CONFIG_NODES_SPAN_OTHER_NODES > +#ifdef CONFIG_NUMA > /* Only safe to use early in boot when initialisation is single-threaded */ > static inline bool __meminit early_pfn_in_nid(unsigned long pfn, int node) > { > -- > 2.7.4 > -- Michal Hocko SUSE Labs