mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabian Krueger <fabian.krueger@fau.de>
To: unlisted-recipients:; (no To-header on input)
Cc: <fabian.krueger@fau.de>,
	Michael Scheiderer <michael.scheiderer@fau.de>,
	<linux-kernel@i4.cs.fau.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/8] staging: kpc2000: introduce usage of __packed
Date: Wed, 26 Jun 2019 09:35:21 +0200	[thread overview]
Message-ID: <20190626073531.8946-4-fabian.krueger@fau.de> (raw)
In-Reply-To: <20190626073531.8946-1-fabian.krueger@fau.de>

Replaced __attribute__((packed)) with __packed. Both ways of attributing
are equivalent, but being shorter, __packed should be preferred.
This refactoring makes the core more readable.

Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
---
 drivers/staging/kpc2000/kpc2000_spi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index c8fdb7e868f8..42d32de2230e 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -114,7 +114,7 @@ struct kp_spi_controller_state {
 
 union kp_spi_config {
 	/* use this to access individual elements */
-	struct __attribute__((packed)) spi_config_bitfield {
+	struct __packed spi_config_bitfield {
 		unsigned int pha       : 1; /* spim_clk Phase      */
 		unsigned int pol       : 1; /* spim_clk Polarity   */
 		unsigned int epol      : 1; /* spim_csx Polarity   */
@@ -133,7 +133,7 @@ union kp_spi_config {
 };
 
 union kp_spi_status {
-	struct __attribute__((packed)) spi_status_bitfield {
+	struct __packed spi_status_bitfield {
 		unsigned int rx    :  1; /* Rx Status       */
 		unsigned int tx    :  1; /* Tx Status       */
 		unsigned int eo    :  1; /* End of Transfer */
@@ -148,7 +148,7 @@ union kp_spi_status {
 };
 
 union kp_spi_ffctrl {
-	struct __attribute__((packed)) spi_ffctrl_bitfield {
+	struct __packed spi_ffctrl_bitfield {
 		unsigned int ffstart :  1; /* FIFO Start */
 		unsigned int         : 31;
 	} bitfield;
-- 
2.17.1


  parent reply	other threads:[~2019-06-26  7:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 11:27 [PATCH 0/8] staging: kpc2000: style refactoring Fabian Krueger
2019-06-25 11:27 ` [PATCH 1/8] staging: kpc2000: add line breaks Fabian Krueger
2019-06-25 11:52   ` Dan Carpenter
2019-06-26  7:35     ` [PATCH 0/8] staging: kpc2000: style refactoring Fabian Krueger
2019-06-26  7:35       ` [PATCH 1/8] staging: kpc2000: add line breaks Fabian Krueger
2019-07-01  8:41         ` Greg Kroah-Hartman
2019-06-26  7:35       ` [PATCH 2/8] staging: kpc2000: blank lines after declaration Fabian Krueger
2019-06-26  7:35       ` Fabian Krueger [this message]
2019-06-26  7:35       ` [PATCH 4/8] staging: kpc2000: remove unnecessary brackets Fabian Krueger
2019-06-26  7:35       ` [PATCH 5/8] staging: kpc2000: add spaces Fabian Krueger
2019-06-26  7:35       ` [PATCH 6/8] staging: kpc2000: introduce 'unsigned int' Fabian Krueger
2019-06-26  7:35       ` [PATCH 7/8] staging: kpc2000: introduce __func__ Fabian Krueger
2019-06-26  7:35       ` [PATCH 8/8] staging: kpc2000: remove needless 'break' Fabian Krueger
2019-06-26  7:50       ` [PATCH 0/8] staging: kpc2000: style refactoring Dan Carpenter
2019-06-25 11:27 ` [PATCH 2/8] staging: kpc2000: blank lines after declaration Fabian Krueger
2019-06-25 11:27 ` [PATCH 3/8] staging: kpc2000: introduce usage of __packed Fabian Krueger
2019-06-25 11:27 ` [PATCH 4/8] staging: kpc2000: add spaces Fabian Krueger
2019-06-25 11:54   ` Dan Carpenter
2019-06-25 11:27 ` [PATCH 5/8] staging: kpc2000: remove unnecessary brackets Fabian Krueger
2019-06-25 11:27 ` [PATCH 6/8] staging: kpc2000: introduce 'unsigned int' Fabian Krueger
2019-06-25 11:55   ` Dan Carpenter
2019-06-25 11:27 ` [PATCH 7/8] staging: kpc2000: introduce __func__ Fabian Krueger
2019-06-25 11:27 ` [PATCH 8/8] staging: kpc2000: remove needless 'break' Fabian Krueger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626073531.8946-4-fabian.krueger@fau.de \
    --to=fabian.krueger@fau.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.scheiderer@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®