From: Yue Hu <zbestahu@gmail.com>
To: gaoxiang25@huawei.com, yuchao0@huawei.com, gregkh@linuxfoundation.org
Cc: linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, huyue2@yulong.com
Subject: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
Date: Wed, 26 Jun 2019 18:39:36 +0800 [thread overview]
Message-ID: <20190626103936.9064-1-zbestahu@gmail.com> (raw)
From: Yue Hu <huyue2@yulong.com>
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
---
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index e51348f..d6e1e16 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
struct erofs_sb_info *sbi = EROFS_I_SB(inode);
const int mode = vi->datamode;
- DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
-
/* should be inode inline C */
if (mode != EROFS_INODE_LAYOUT_INLINE)
return 0;
--
1.9.1
next reply other threads:[~2019-06-26 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:39 Yue Hu [this message]
2019-06-26 10:51 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2019-06-26 3:28 Yue Hu
2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626103936.9064-1-zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huyue2@yulong.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®