mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [RFC][PATCH] regmap: Drop CONFIG_64BIT checks from core
Date: Wed, 26 Jun 2019 13:05:49 +0100	[thread overview]
Message-ID: <20190626120549.GC5316@sirena.org.uk> (raw)
In-Reply-To: <f0098753-8219-27c0-d992-a209f3c67d4d@denx.de>

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Wed, Jun 26, 2019 at 01:20:17PM +0200, Marek Vasut wrote:
> On 6/26/19 1:15 PM, Mark Brown wrote:

> > registers was that we use unsigned long for
> > addresses and values and a 64 bit value won't fit in those on a 32 bit
> > system.  Some of the bulk APIs will work but things like individual
> > register writes and the caches will have problems.

> Good thing I sent this as RFC, I realized that shortly after too.

> So, what would be the suggestion here ?

I think if I had any really good ideas I'd have done it at the time :/
Converting to unsigned long long is going to hurt performance for the
common case but it'd probably be what we need to do, I think we'd need
to have some sort of preprocessor fun and build two copies of the code
with a 64 bit clean version available for devices that need it which is
ugly but bleh.  It's how we handle similar issues with zlib.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2019-06-26 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 23:31 Marek Vasut
2019-06-26 11:15 ` Mark Brown
2019-06-26 11:20   ` Marek Vasut
2019-06-26 12:05     ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626120549.GC5316@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®