From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2E4C48BD6 for ; Wed, 26 Jun 2019 22:25:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C18C21743 for ; Wed, 26 Jun 2019 22:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561587956; bh=dWrZzF/XhnDsjGoEGdLBbSVqFhzeMu0M8np8rL3DeVs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rtjQAXAYH5+uaTAmHbn4g4Zcp2uFIgFYQkuU5RJOsDBmUvN3Gwrvkr36p1mQwMwa1 uQvBjhfCpO68Sr7O0V/48zwav95pNX5jWfev1+4gXJ4w1/B80MK1eT0gCl3gOmES3I dqWJea7p/Isp1+wTtoNjvoAUexTdeBfbM4wRTwbE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfFZWZz (ORCPT ); Wed, 26 Jun 2019 18:25:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:47934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfFZWZy (ORCPT ); Wed, 26 Jun 2019 18:25:54 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB52421738; Wed, 26 Jun 2019 22:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561587954; bh=dWrZzF/XhnDsjGoEGdLBbSVqFhzeMu0M8np8rL3DeVs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mssNCvDXM3lIy9mHu47Fi5QIRccIP4NEIrmBc+mQHupnTW7+YYbhguOoXDqtvERvH REfZC+aT9ppRRnmbB7/H8Yp47SEvjMSnzviL8SITVJOqWUzWaWRjUa5YprDOQSdFxO pQ6Rdu5QWpA8GqFoZXwWmNRKk1ID+8M77YZ7zkKo= Date: Wed, 26 Jun 2019 15:25:53 -0700 From: Andrew Morton To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Tejun Heo , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH] memcg: Add kmem.slabinfo to v2 for debugging purpose Message-Id: <20190626152553.6f9178a0361e699a5d53e360@linux-foundation.org> In-Reply-To: <20190626165614.18586-1-longman@redhat.com> References: <20190626165614.18586-1-longman@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jun 2019 12:56:14 -0400 Waiman Long wrote: > With memory cgroup v1, there is a kmem.slabinfo file that can be > used to view what slabs are allocated to the memory cgroup. There > is currently no such equivalent in memory cgroup v2. This file can > be useful for debugging purpose. > > This patch adds an equivalent kmem.slabinfo to v2 with the caveat that > this file will only show up as ".__DEBUG__.memory.kmem.slabinfo" when the > "cgroup_debug" parameter is specified in the kernel boot command line. > This is to avoid cluttering the cgroup v2 interface with files that > are seldom used by end users. > > ... > > mm/memcontrol.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) A change to the kernel's user interface triggers a change to the kernel's user interface documentation. This should be automatic by now :(