From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3149C48BD9 for ; Thu, 27 Jun 2019 00:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D53B20815 for ; Thu, 27 Jun 2019 00:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561595068; bh=alD1se/H8oSgNNFyrIfLo/Nfix2/7MSIr7dtHdEMxz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=siheGNgRG2B2PkiS4l3FGKKJ7J8/BKinQa9spshG1aH+LV4/IQKv6xzycm/CsdR0a psKfvikKspGr6/tG99c8pAPovsUg7UAr5RBOtJpEGeAF/kMDmYP45kQzq9MiamQEti C1ajx8iwQ/6F+3h+gUNFRQsJB/A5k6nqDYdPBFYc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbfF0AY1 (ORCPT ); Wed, 26 Jun 2019 20:24:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:59896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfF0AY0 (ORCPT ); Wed, 26 Jun 2019 20:24:26 -0400 Received: from localhost (unknown [107.242.116.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89F2820815; Thu, 27 Jun 2019 00:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561595066; bh=alD1se/H8oSgNNFyrIfLo/Nfix2/7MSIr7dtHdEMxz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nUE3ssRAsi7TSkJaT84htx3XrfeVIZO8w2Ah4D0LMJGbTSnCKtsVdGMDNqzj04zoQ yWPiIQMdlZWcsPvXMQnUJDgwHLgl4zv+tC+Pdo87oXr7HimLZf24Izawzep8WHCLWq CVxNTKOwX5JTuZm/dTlmAxGMYvdBRRNXjBFXknww= Date: Wed, 26 Jun 2019 20:24:22 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ranjani Sridharan , "kernelci . org bot" Subject: Re: [PATCH AUTOSEL 5.1 38/51] ASoC: core: Fix deadlock in snd_soc_instantiate_card() Message-ID: <20190627002422.GO7898@sasha-vm> References: <20190626034117.23247-1-sashal@kernel.org> <20190626034117.23247-38-sashal@kernel.org> <20190626103912.GW5316@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190626103912.GW5316@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 26, 2019 at 11:39:12AM +0100, Mark Brown wrote: >On Tue, Jun 25, 2019 at 11:40:54PM -0400, Sasha Levin wrote: >> From: Ranjani Sridharan >> >> [ Upstream commit 495f926c68ddb905a7a0192963096138c6a934e1 ] >> >> Move the client_mutex lock to snd_soc_unbind_card() before >> removing link components. This prevents the deadlock >> in the error path in snd_soc_instantiate_card(). > >Again, are you sure there's no dependencies? I'm taking the patch it depends on (also a fix) as part of this AUTOSEL branch. -- Thanks, Sasha