From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82130C48BD6 for ; Thu, 27 Jun 2019 03:25:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5235C216E3 for ; Thu, 27 Jun 2019 03:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p73g0i/l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbfF0DZf (ORCPT ); Wed, 26 Jun 2019 23:25:35 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39537 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfF0DZf (ORCPT ); Wed, 26 Jun 2019 23:25:35 -0400 Received: by mail-ot1-f66.google.com with SMTP id r21so99567otq.6 for ; Wed, 26 Jun 2019 20:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HjN3R4taWV9ZkzqtfFfYqtTJoGWa+sVZ87kMP8YXV64=; b=p73g0i/lWc+fOBoO5RiaEgcznFDaujrFRpK8nrpjNqvGjrawC2EaPVvV4w+W4qMSNj kPn5pFRhuvQUd9x2sgIAVHXF2eeTLxWFP/Q58yokH46HloqfSSpAeKShM5EbcaODu9M6 QznKz+hpJersSvp2oXpnu1SX3GtQQFR6urwFGAEDK4trHAPFepXs+Gg0ZVamM/NH5T11 6avK6vXC6QN0QSrYQ+Une0tiKfRAHPum6xt4rRhPYQzmiH1CKrAdACQCVRJFkhGJR76J GshTMOVTzJFEPyZKt49AKANlEsI5xpd9uxfcHBqSRQ7LzU3VYAkPffH6bH40AxELynMj DbrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HjN3R4taWV9ZkzqtfFfYqtTJoGWa+sVZ87kMP8YXV64=; b=K+cVrzLf8pKOsG+DRae+teZ2HiesynZZmEm2yutvaaZf8oBM1LoJIkWKf5oke4x8km 4CctEk3oMOfMxkAyF8mJWfnPQxqAiepe5uf+pVlfjiz1UgzzWAIBgCXgc2PJE10tFQ6u MuV27/BqiCHtiMk6u/mlB+EFSMFSaRoGxFh6G4IT3RSI0fkkXneoyptbcueZ2HNSrFlW DR4GWfChJKj12FbXFIgDih69NZxBNMhuORIUoiAKKA/ZrzqcwFYJRhfm4LTZE/rpHqsw ZjtvDMhehng8noLp/DtMXdvQ3wZitfaTaXH6QP4zkRVcZY9hG/VlYc7qpqJ9zICIGW4b Ir5w== X-Gm-Message-State: APjAAAWdl6x+NPHdz/K9tonsduaMjTrdfQM8yLh22wyk1AuzWb/ai8Dx adFlaz07PBxmrkT2A/agg/E= X-Google-Smtp-Source: APXvYqw8EnmlfwshdOVKyWDk3h/vd06XTuBwLqic2iEJQoYlW52eCytOnrZasY+djy59hIiS3GdOEw== X-Received: by 2002:a9d:6385:: with SMTP id w5mr1320187otk.227.1561605934166; Wed, 26 Jun 2019 20:25:34 -0700 (PDT) Received: from rYz3n.attlocal.net ([2600:1700:210:3790::48]) by smtp.googlemail.com with ESMTPSA id y184sm417647oie.33.2019.06.26.20.25.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 20:25:33 -0700 (PDT) From: Jiunn Chang To: skhan@linuxfoundation.org Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: [Linux-kernel-mentees][PATCH] ethtool: Fix undefined behavior in bit shift Date: Wed, 26 Jun 2019 22:25:29 -0500 Message-Id: <20190627032532.18374-1-c0d1n61at3@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Signed-off-by: Jiunn Chang --- include/uapi/linux/ethtool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 3534ce157ae9..859b2e99c000 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -1691,7 +1691,7 @@ static inline int ethtool_validate_duplex(__u8 duplex) #define RXH_IP_DST (1 << 5) #define RXH_L4_B_0_1 (1 << 6) /* src port in case of TCP/UDP/SCTP */ #define RXH_L4_B_2_3 (1 << 7) /* dst port in case of TCP/UDP/SCTP */ -#define RXH_DISCARD (1 << 31) +#define RXH_DISCARD (1U << 31) #define RX_CLS_FLOW_DISC 0xffffffffffffffffULL #define RX_CLS_FLOW_WAKE 0xfffffffffffffffeULL -- 2.22.0