From: Christoph Hellwig <hch@infradead.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
paul.walmsley@sifive.com, palmer@sifive.com,
aou@eecs.berkeley.edu, sachin.ghadi@sifive.com
Subject: Re: [PATCH] riscv: ccache: Remove unused variable
Date: Thu, 27 Jun 2019 01:59:26 -0700 [thread overview]
Message-ID: <20190627085926.GA15810@infradead.org> (raw)
In-Reply-To: <1561624486-22867-1-git-send-email-yash.shah@sifive.com>
On Thu, Jun 27, 2019 at 02:04:46PM +0530, Yash Shah wrote:
> Reading the count register clears the interrupt signal. Currently, the
> count registers are read into 'regval' variable but the variable is
> never used. Therefore remove it.
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> arch/riscv/mm/sifive_l2_cache.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Unrelated note: that driver absolutely does not belong into
arch/riscv/mm. arch/$(ARCH)/mm is for architecte-specific memory
management code, not for random drivers.
next prev parent reply other threads:[~2019-06-27 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 8:34 Yash Shah
2019-06-27 8:59 ` Christoph Hellwig [this message]
2019-06-27 16:13 ` Paul Walmsley
2019-06-28 4:55 ` Yash Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627085926.GA15810@infradead.org \
--to=hch@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®