From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: aviad.krawczyk@huawei.com, xuechaojing@huawei.com,
jesse.brandeburg@intel.com, zhaochen6@huawei.com,
edumazet@google.com, dann.frazier@canonical.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hinic: reduce rss_init stack usage
Date: Fri, 28 Jun 2019 09:32:15 -0700 (PDT) [thread overview]
Message-ID: <20190628.093215.173840298920978641.davem@davemloft.net> (raw)
In-Reply-To: <20190628103158.2446356-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 28 Jun 2019 12:31:44 +0200
> On 32-bit architectures, putting an array of 256 u32 values on the
> stack uses more space than the warning limit:
>
> drivers/net/ethernet/huawei/hinic/hinic_main.c: In function 'hinic_rss_init':
> drivers/net/ethernet/huawei/hinic/hinic_main.c:286:1: error: the frame size of 1068 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> I considered changing the code to use u8 values here, since that's
> all the hardware supports, but dynamically allocating the array is
> a more isolated fix here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net-next.
Arnd, please make it clear what tree you are targetting in the
future. Thank you.
next prev parent reply other threads:[~2019-06-28 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:31 Arnd Bergmann
2019-06-28 16:32 ` David Miller [this message]
2019-07-01 15:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628.093215.173840298920978641.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=aviad.krawczyk@huawei.com \
--cc=dann.frazier@canonical.com \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xuechaojing@huawei.com \
--cc=zhaochen6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®