From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91271C5B579 for ; Fri, 28 Jun 2019 10:46:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A2A0208E3 for ; Fri, 28 Jun 2019 10:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfF1Kql (ORCPT ); Fri, 28 Jun 2019 06:46:41 -0400 Received: from foss.arm.com ([217.140.110.172]:44966 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfF1Kql (ORCPT ); Fri, 28 Jun 2019 06:46:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5694728; Fri, 28 Jun 2019 03:46:40 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 030B13F718; Fri, 28 Jun 2019 03:46:38 -0700 (PDT) Date: Fri, 28 Jun 2019 11:46:30 +0100 From: Lorenzo Pieralisi To: Arnd Bergmann Cc: Thierry Reding , Bjorn Helgaas , Jonathan Hunter , Manikanta Maddireddy , Thierry Reding , Vidya Sagar , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: tegra: use correct gpio/consumer.h header Message-ID: <20190628104630.GA19883@e121166-lin.cambridge.arm.com> References: <20190628102953.2369879-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628102953.2369879-1-arnd@arndb.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2019 at 12:29:45PM +0200, Arnd Bergmann wrote: > linux/gpio.h is not the correct header for modern interfaces and > causes a build failure without CONFIG_GPIOLIB: > > drivers/pci/controller/pci-tegra.c: In function 'tegra_pcie_port_reset': > drivers/pci/controller/pci-tegra.c:551:3: error: implicit declaration of function 'gpiod_set_value'; did you mean 'gpio_set_value'? [-Werror=implicit-function-declaration] > gpiod_set_value(port->reset_gpio, 1); > ^~~~~~~~~~~~~~~ > > Use linux/gpio/consumer.h instead. > > Fixes: 5e5e9c23f82a ("PCI: tegra: Add support for GPIO based PERST#") > Signed-off-by: Arnd Bergmann > --- > drivers/pci/controller/pci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Squashed in the respective commit in pci/tegra, thanks for the fix Arnd. Lorenzo > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 9cc03a2549c0..1775b88c0aec 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -17,7 +17,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > -- > 2.20.0 >