From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4EFAC0650E for ; Mon, 1 Jul 2019 15:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B970520659 for ; Mon, 1 Jul 2019 15:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561994779; bh=f6Vhp2JOFVYPly+oy0IG8d1NArRJ8kNupx/z8r2urwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fbSdUxQ1e91G2QFPE0HppJxRpw24kqV/2VuzeKwFowtoOO8A/Zh3aL0qIOlY2k5dd l43T4//NF6OTjbIWiVD7fLZ4z9+44bP9w+D4ZHQZrVo7AcJ0gRb+Tu7Egq8zPQQovB yDal58ilCjIkHPx4KOspOvwcg+EH+VJDkvSsCojI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728830AbfGAP0K (ORCPT ); Mon, 1 Jul 2019 11:26:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:38172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727810AbfGAP0K (ORCPT ); Mon, 1 Jul 2019 11:26:10 -0400 Received: from localhost (unknown [122.167.76.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87AEA208E4; Mon, 1 Jul 2019 15:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561994769; bh=f6Vhp2JOFVYPly+oy0IG8d1NArRJ8kNupx/z8r2urwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eiiDwTWvFvNOl3K8T00Vo2UnctJIxYxlt6zhzuO7ORU54jGeuPKdtwfTUf5502fzU 0wu7iTvRGN0MoLWVhliMIZI5Osqz8gGpVyrbVSI5pLOCVSjzOUQT5o7qHplOxU2XtV pSXSQoMsD4jqvZzQDUJcb4yQzOVu4b5WFN72xhFo= Date: Mon, 1 Jul 2019 20:52:57 +0530 From: Vinod Koul To: Jorge Ramirez-Ortiz Cc: agross@kernel.org, adrian.hunter@intel.com, ulf.hansson@linaro.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org Subject: Re: [PATCH v2] mmc: sdhci-msm: fix mutex while in spinlock Message-ID: <20190701152257.GM2911@vkoul-mobl> References: <20190701150125.2602-1-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701150125.2602-1-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-07-19, 17:01, Jorge Ramirez-Ortiz wrote: > mutexes can sleep and therefore should not be taken while holding a > spinlock. move clk_get_rate (can sleep) outside the spinlock protected > region. Reviewed-by: Vinod Koul -- ~Vinod