From: YueHaibing <yuehaibing@huawei.com>
To: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
David Howells <dhowells@redhat.com>,
Kairui Song <kasong@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Mimi Zohar <zohar@linux.ibm.com>,
"Thiago Jung Bauermann" <bauerman@linux.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>,
"Eric Biggers" <ebiggers@google.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] integrity: Remove set but not used variable 'acl'
Date: Wed, 3 Jul 2019 02:55:18 +0000 [thread overview]
Message-ID: <20190703025518.6379-1-yuehaibing@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
security/integrity/digsig.c: In function 'integrity_init_keyring':
security/integrity/digsig.c:99:18: warning:
variable 'acl' set but not used [-Wunused-but-set-variable]
It seems 'acl' is needed in __integrity_init_keyring
Fixes: 6100ac53909d ("keys: Replace uid/gid/perm permissions checking with an ACL")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
security/integrity/digsig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
index 1f2c43f62047..f9f3c8ffe786 100644
--- a/security/integrity/digsig.c
+++ b/security/integrity/digsig.c
@@ -114,7 +114,7 @@ int __init integrity_init_keyring(const unsigned int id)
acl = &internal_writable_keyring_acl;
out:
- return __integrity_init_keyring(id, &internal_keyring_acl, restriction);
+ return __integrity_init_keyring(id, acl, restriction);
}
static int __init integrity_add_key(const unsigned int id, const void *data,
next reply other threads:[~2019-07-03 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 2:55 YueHaibing [this message]
2019-07-03 13:57 ` David Howells
2019-07-04 1:23 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703025518.6379-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bauerman@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=jmorris@namei.org \
--cc=kasong@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®