From: Jason Gunthorpe <jgg@ziepe.ca>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Kamal Heib <kamalheib1@gmail.com>,
Feras Daoud <ferasda@mellanox.com>,
Erez Shitrit <erezsh@mellanox.com>,
Bart Van Assche <bvanassche@acm.org>,
Aaron Knister <aaron.s.knister@nasa.gov>,
Denis Drozdov <denisd@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 28/87] infiniband: ulp: remove memset after vzalloc in ipoib_cm.c
Date: Wed, 3 Jul 2019 14:29:38 -0300 [thread overview]
Message-ID: <20190703172938.GA10574@ziepe.ca> (raw)
In-Reply-To: <20190627173806.3307-1-huangfq.daxian@gmail.com>
On Fri, Jun 28, 2019 at 01:38:04AM +0800, Fuqian Huang wrote:
> vzalloc has already zeroed the memory.
> So memset is unneeded.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> drivers/infiniband/ulp/ipoib/ipoib_cm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> index aa9dcfc36cd3..c59e00a0881f 100644
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> @@ -1153,7 +1153,6 @@ static int ipoib_cm_tx_init(struct ipoib_cm_tx *p, u32 qpn,
> ret = -ENOMEM;
> goto err_tx;
> }
> - memset(p->tx_ring, 0, ipoib_sendq_size * sizeof(*p->tx_ring));
>
> p->qp = ipoib_cm_create_tx_qp(p->dev, p);
> memalloc_noio_restore(noio_flag);
Applied to for-next
Thanks,
Jason
prev parent reply other threads:[~2019-07-03 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 17:38 Fuqian Huang
2019-07-03 17:29 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703172938.GA10574@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aaron.s.knister@nasa.gov \
--cc=bvanassche@acm.org \
--cc=denisd@mellanox.com \
--cc=dledford@redhat.com \
--cc=erezsh@mellanox.com \
--cc=ferasda@mellanox.com \
--cc=huangfq.daxian@gmail.com \
--cc=kamalheib1@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®