From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291E4C06511 for ; Wed, 3 Jul 2019 18:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0460E218B8 for ; Wed, 3 Jul 2019 18:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="GdaPl4pS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727184AbfGCSD7 (ORCPT ); Wed, 3 Jul 2019 14:03:59 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41523 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbfGCSD6 (ORCPT ); Wed, 3 Jul 2019 14:03:58 -0400 Received: by mail-qk1-f196.google.com with SMTP id v22so3517807qkj.8 for ; Wed, 03 Jul 2019 11:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to:user-agent; bh=lYX4hArZqbN+eTGDydHx247smNMZP20ckzpDZYDyj70=; b=GdaPl4pS25oGRqKqhYVZvbGMctmnAHGdnVDY5M9r5E2gXod6kvV8ztPBkFUZyGMM4s clYw/MlR3HpP4fUWkXGOqUyErs3qjITlzLbXXg12O9Tm+nYZZaTCWOpGAzeQajKuGTZU 0wZmmTjqvm2YnyiIapY0xjU8UbEcBknZzuv1w7IATnd4Sq1IJThXnD3h4aGhqzdo2ww1 6dYcSuMv9naAdmn53AoZUwIOgY2ixkhgWUgG5M3h3qNUG7OVco2Jf970+GkH9fxchzv1 Bwym1bXm36Zd5IvXjxpJKkA7FdRhwbFO3vyAQP2p0NEj/n2Yq8GEnqIn5HF5aibZNjgw i3Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to:user-agent; bh=lYX4hArZqbN+eTGDydHx247smNMZP20ckzpDZYDyj70=; b=cyQb2Nn8jYq+RfxDaMB6+eNGBWEN4MqfzOtxURBfKPiv1DfxdmJcmIa/I6bwz6jU9M +iV6CPymY73nAy2OWVGu9tGrwzBc+czraTQqmID02JgvAn0H8ecEV89zNBNHFyPcpeXc gJ+YSYhrO/34GLcTM2bZjbzE+58af56QLxrDYnLUpTBFag8CADcHChLD8cDg4SZM4Fbt olGWgV9PKdQ1D07RO5W4+YxYttLcgsqEcfD8faFAbTQZQxwwZPieLgirQtU7KDom0fTj xNaUwTOfyFZlVrNVHY+IUwBjPUm0/leCu9SkuSQDuFSG8cdBTlg9Miycs4hYdcxSiEz/ vNYg== X-Gm-Message-State: APjAAAU9UcJwD76i28KqAw/xKUUeaRJ8KKbzb9vExsa89kfwPUWbsshq fB3Dg0c7wYLG/ALUO92U3+11Xg== X-Google-Smtp-Source: APXvYqwAIbwqmaDg6afMKDuszd1tCKqefer9BuJ/SUVOZEN2k8Xz9Vx5WhWvm0C4hIeiM5DGRjiLAw== X-Received: by 2002:a37:a10b:: with SMTP id k11mr29660901qke.76.1562177037895; Wed, 03 Jul 2019 11:03:57 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id f132sm1237440qke.88.2019.07.03.11.03.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 11:03:57 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hijbp-0006qR-01; Wed, 03 Jul 2019 15:03:57 -0300 Date: Wed, 3 Jul 2019 15:03:56 -0300 From: Jason Gunthorpe To: Christoph Hellwig , AlexDeucher Cc: Dan Williams , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ben Skeggs , Ira Weiny , linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/22] mm: move hmm_vma_fault to nouveau Message-ID: <20190703180356.GB18673@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701062020.19239-21-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 01, 2019 at 08:20:18AM +0200, Christoph Hellwig wrote: > hmm_vma_fault is marked as a legacy API to get rid of, but quite suites > the current nouvea flow. Move it to the only user in preparation for > fixing a locking bug involving caller and callee. > > Signed-off-by: Christoph Hellwig > drivers/gpu/drm/nouveau/nouveau_svm.c | 54 ++++++++++++++++++++++++++- > include/linux/hmm.h | 54 --------------------------- > 2 files changed, 53 insertions(+), 55 deletions(-) I was thinking about doing exactly this too, but amdgpu started using this already obsolete API in their latest driver :( So, we now need to get both drivers to move to the modern API. Jason