From: "Simon Sandström" <simon@nikanor.nu>
To: gregkh@linuxfoundation.org
Cc: gneukum1@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
"Simon Sandström" <simon@nikanor.nu>
Subject: [PATCH 3/3] staging: kpc2000: simplify comparison to NULL in fileops.c
Date: Thu, 4 Jul 2019 08:08:11 +0200 [thread overview]
Message-ID: <20190704060811.10330-4-simon@nikanor.nu> (raw)
In-Reply-To: <20190704060811.10330-1-simon@nikanor.nu>
Fixes checkpatch warning "Comparison to NULL could be written [...]".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
---
drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c
index 7feb2fde0db2..48ca88bc6b0b 100644
--- a/drivers/staging/kpc2000/kpc_dma/fileops.c
+++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
@@ -247,7 +247,7 @@ int kpc_dma_open(struct inode *inode, struct file *filp)
struct dev_private_data *priv;
struct kpc_dma_device *ldev = kpc_dma_lookup_device(iminor(inode));
- if (ldev == NULL)
+ if (!ldev)
return -ENODEV;
if (!atomic_dec_and_test(&ldev->open_count)) {
--
2.20.1
prev parent reply other threads:[~2019-07-04 6:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 6:08 [PATCH 0/3] Simplify NULL comparisons in staging/kpc2000 Simon Sandström
2019-07-04 6:08 ` [PATCH 1/3] staging: kpc2000: simplify comparison to NULL in kpc2000_spi.c Simon Sandström
2019-07-04 6:08 ` [PATCH 2/3] staging: kpc2000: simplify comparison to NULL in dma.c Simon Sandström
2019-07-04 6:08 ` Simon Sandström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704060811.10330-4-simon@nikanor.nu \
--to=simon@nikanor.nu \
--cc=devel@driverdev.osuosl.org \
--cc=gneukum1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®