From: Mark Brown <broonie@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: wens@csie.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: axp20x: fix DCDCA and DCDCD for AXP806
Date: Mon, 8 Jul 2019 16:31:22 +0100 [thread overview]
Message-ID: <20190708153122.GA14859@sirena.co.uk> (raw)
In-Reply-To: <24416869.PQYcAB5yxk@jernej-laptop>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Sat, Jul 06, 2019 at 02:44:03PM +0200, Jernej Škrabec wrote:
> Dne sobota, 06. julij 2019 ob 13:21:44 CEST je Mark Brown napisal(a):
> > This is not a great changelog - what are the bugs and how does
> > this patch fix them?
> In case of DCDCA, number of steps for second range should be 20 (0x14), but it
> was set to 14. So I guess patch author missed "0x". Currently, math doesn't
> work, because sum of both number of steps plus 2 must be equal to number of
> voltages macro.
> Same error is present in AXP803 DCDC6 regulator.
> In case of DCDCD, array of ranges (axp806_dcdcd_ranges) contains two ranges,
> which use same start and end macros. By checking datasheet or just checking
> macros at the top of the source file, it's obvious that "1" is missing in
> second range macro names (1600 instead of 600).
Can you please resend these with changelogs on the relevant
patches so they can be reviewed more sensibly?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-08 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 10:05 [PATCH 0/2] regulator: axp20x: Fix bugs for AXP803/6 Jernej Skrabec
2019-07-06 10:05 ` [PATCH 1/2] regulator: axp20x: fix DCDCA and DCDCD for AXP806 Jernej Skrabec
2019-07-06 11:21 ` Mark Brown
2019-07-06 12:44 ` Jernej Škrabec
2019-07-08 15:31 ` Mark Brown [this message]
2019-07-06 10:05 ` [PATCH 2/2] regulator: axp20x: fix DCDC6 for AXP803 Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708153122.GA14859@sirena.co.uk \
--to=broonie@kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®