mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Garnier <thgarnie@chromium.org>
To: kernel-hardening@lists.openwall.com
Cc: kristen@linux.intel.com, keescook@chromium.org,
	Thomas Garnier <thgarnie@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
	Len Brown <len.brown@intel.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v8 06/11] x86/CPU: Adapt assembly for PIE support
Date: Mon,  8 Jul 2019 10:48:59 -0700	[thread overview]
Message-ID: <20190708174913.123308-7-thgarnie@chromium.org> (raw)
In-Reply-To: <20190708174913.123308-1-thgarnie@chromium.org>

Change the assembly code to use only relative references of symbols for the
kernel to be PIE compatible. Use the new _ASM_MOVABS macro instead of
the 'mov $symbol, %dst' construct.

Position Independent Executable (PIE) support will allow to extend the
KASLR randomization range below 0xffffffff80000000.

Signed-off-by: Thomas Garnier <thgarnie@chromium.org>
---
 arch/x86/include/asm/processor.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 3eab6ece52b4..3e2154b0e09f 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -713,11 +713,13 @@ static inline void sync_core(void)
 		"pushfq\n\t"
 		"mov %%cs, %0\n\t"
 		"pushq %q0\n\t"
-		"pushq $1f\n\t"
+		"movabsq $1f, %q0\n\t"
+		"pushq %q0\n\t"
 		"iretq\n\t"
 		UNWIND_HINT_RESTORE
 		"1:"
-		: "=&r" (tmp), ASM_CALL_CONSTRAINT : : "cc", "memory");
+		: "=&r" (tmp), ASM_CALL_CONSTRAINT
+		: : "cc", "memory");
 #endif
 }
 
-- 
2.22.0.410.gd8fdbe21b5-goog


  parent reply	other threads:[~2019-07-08 17:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 17:48 [PATCH v8 00/11] x86: PIE support to extend KASLR randomization Thomas Garnier
2019-07-08 17:48 ` [PATCH v8 01/11] x86/crypto: Adapt assembly for PIE support Thomas Garnier
2019-07-08 17:48 ` [PATCH v8 02/11] x86: Add macro to get symbol address " Thomas Garnier
2019-07-08 17:48 ` [PATCH v8 03/11] x86: relocate_kernel - Adapt assembly " Thomas Garnier
2019-07-08 17:48 ` [PATCH v8 04/11] x86/entry/64: " Thomas Garnier
2019-07-08 17:48 ` [PATCH v8 05/11] x86: pm-trace - " Thomas Garnier
2019-07-08 17:48 ` Thomas Garnier [this message]
2019-07-08 17:49 ` [PATCH v8 07/11] x86/acpi: " Thomas Garnier
2019-07-08 17:49 ` [PATCH v8 08/11] x86/boot/64: " Thomas Garnier
2019-07-08 17:49 ` [PATCH v8 09/11] x86/power/64: " Thomas Garnier
2019-07-08 17:49 ` [PATCH v8 10/11] x86/paravirt: " Thomas Garnier
2019-07-08 17:49 ` [PATCH v8 11/11] x86/alternatives: " Thomas Garnier
2019-07-30 18:01 ` [PATCH v8 00/11] x86: PIE support to extend KASLR randomization Kees Cook
2019-07-30 19:09   ` Thomas Garnier
2019-07-08 19:09 [PATCH v8 06/11] x86/CPU: Adapt assembly for PIE support Alexey Dobriyan
2019-07-08 19:35 ` Thomas Garnier
2019-07-09 18:39   ` Alexey Dobriyan
2019-07-09 18:47     ` Thomas Garnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708174913.123308-7-thgarnie@chromium.org \
    --to=thgarnie@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kristen@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®