From: "J. Bruce Fields" <bfields@fieldses.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: chuck.lever@oracle.com, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH -next] nfsd: Make __get_nfsdfs_client() static
Date: Tue, 9 Jul 2019 19:36:56 -0400 [thread overview]
Message-ID: <20190709233656.GC1536@fieldses.org> (raw)
In-Reply-To: <20190708125408.56016-1-yuehaibing@huawei.com>
Thanks, applied.--b.
On Mon, Jul 08, 2019 at 08:54:08PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> fs/nfsd/nfsctl.c:1221:22: warning:
> symbol '__get_nfsdfs_client' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 53833b3..0a9a49d 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1218,7 +1218,7 @@ static void clear_ncl(struct inode *inode)
> }
>
>
> -struct nfsdfs_client *__get_nfsdfs_client(struct inode *inode)
> +static struct nfsdfs_client *__get_nfsdfs_client(struct inode *inode)
> {
> struct nfsdfs_client *nc = inode->i_private;
>
> --
> 2.7.4
>
prev parent reply other threads:[~2019-07-09 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 12:54 YueHaibing
2019-07-09 23:36 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709233656.GC1536@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome