From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F80C74A36 for ; Wed, 10 Jul 2019 18:26:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18CC2216E3 for ; Wed, 10 Jul 2019 18:26:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="nHTREbiy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbfGJS01 (ORCPT ); Wed, 10 Jul 2019 14:26:27 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:35091 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbfGJS01 (ORCPT ); Wed, 10 Jul 2019 14:26:27 -0400 Received: by mail-qk1-f193.google.com with SMTP id r21so2705283qke.2 for ; Wed, 10 Jul 2019 11:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g2+6yeYN+3vI29rODOmLOhqDB3fSrrUGXJ7yMKJfWBA=; b=nHTREbiykhoxsXUKbKVDSyCrN9c1C+4e+EPeTqBJfniHHpLXBTAQ5/6FJhrlG0OmNy LDI2ZrHB/YWFEeYno4nlYcqMMaDxG4p4vYKjpcHX4m0wvU+VutA5sAu+1FKcIboPjp41 LejgcDFeqRGHyOLQu/6AQE5ocMW13bW9Apj1L5NtqlCf8ihRJuu3a3cuo6+EbaX/DnmJ s3LWaYjPB56WRS2bDdv1euUVESWEecbR6ZQ5ML+GERIcgeHFPSCmtJrvsVHaB7w2/Zdc cduq0R8tdGcJAstHZW75gbZNvWoWVS5SwWgfu5xj0kvrk0lUcMqvbZ71FudVk1n/0vRZ cGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g2+6yeYN+3vI29rODOmLOhqDB3fSrrUGXJ7yMKJfWBA=; b=CgGgkINm8lsQxT0YctlpGS7thaO4u2vLpvpkyvc2SHly/je+GU/TAzKw9rTqcT1mPH SdJkPCd9PJnSB/ku4dK8a+yKfNyhVukfX2bKXlk4tnXktAnlURIAGr00x+410RQ6PjYK cv+ZDXT6L8zMIf1Zd1htdINP0UsYWfLRpAoYnBUt8Lw1AibiCWeyLx3WfftyyX7r7aez dkMdb/lzESCArZ2/2uFc7HxKYCkeMo8TKy7C+4s0kel6T3ZYLgBdp5NR7JzkZlqWb8/p MtQ6y0Czodsb2JVGwURdb6qSKeKEQZxUpsQnU9XwtrYUfvVp98lQ3BUPllDGvRPUB3l8 0Z6Q== X-Gm-Message-State: APjAAAX+gnB8G0QT28tLy4bvaKGfI7c4UXqwgkmSmPzmDcpJixnWoxOV mcAuctEMNStK81SQ7UOVrVEA4g== X-Google-Smtp-Source: APXvYqwfZcwhFY9pJB/xMLdQlIh6iSHBKEb0/JDEEeFmpBZa/4TMmX4e2vCJC6uxFdd/4HVuFcZjsg== X-Received: by 2002:a37:4e8f:: with SMTP id c137mr24147053qkb.127.1562783186289; Wed, 10 Jul 2019 11:26:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id w16sm1303926qki.36.2019.07.10.11.26.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jul 2019 11:26:25 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hlHIO-00023S-VL; Wed, 10 Jul 2019 15:26:24 -0300 Date: Wed, 10 Jul 2019 15:26:24 -0300 From: Jason Gunthorpe To: Nathan Chancellor Cc: Bernard Metzler , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] rdma/siw: Use proper enumerated type in map_cqe_status Message-ID: <20190710182624.GG4051@ziepe.ca> References: <20190710174800.34451-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710174800.34451-1-natechancellor@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 10:48:00AM -0700, Nathan Chancellor wrote: > clang warns several times: > > drivers/infiniband/sw/siw/siw_cq.c:31:4: warning: implicit conversion > from enumeration type 'enum siw_wc_status' to different enumeration type > 'enum siw_opcode' [-Wenum-conversion] > { SIW_WC_SUCCESS, IB_WC_SUCCESS }, > ~ ^~~~~~~~~~~~~~ > > Fixes: b0fff7317bb4 ("rdma/siw: completion queue methods") > Link: https://github.com/ClangBuiltLinux/linux/issues/596 > Signed-off-by: Nathan Chancellor > --- > drivers/infiniband/sw/siw/siw_cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Weird that gcc doesn't warn on this by default.. Applied to for-next, thanks Jason