From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F80C742D2 for ; Fri, 12 Jul 2019 17:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D3EB204FD for ; Fri, 12 Jul 2019 17:45:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ntIle1vF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbfGLRp1 (ORCPT ); Fri, 12 Jul 2019 13:45:27 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:43353 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfGLRp1 (ORCPT ); Fri, 12 Jul 2019 13:45:27 -0400 Received: by mail-qk1-f194.google.com with SMTP id m14so6987594qka.10 for ; Fri, 12 Jul 2019 10:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0z5HbMzk+TNHcYVHCO/5rmn/u7ficHQ0wbbFTmo5UzU=; b=ntIle1vFd4ZRdhL76VdsyNncHbXMdq6YNaWmDXrUKzA+t8Vh0t4u+t7axMcNHs0iuw +6BMZPBIubJ/OADehqKIjDhkvwuy+nA1yXtaPdRNNCEGjETMn+QSWuolgrprj/tTsHV/ wOa7AY/RdD5MwyK+uag+ltgfrIaM5XwVSVgBV2+w1C/cqFSKXbZIq9M6wdgGWt5IQ9ni BoHdbjyXjLcddyWoUDcw5j4m9hccSbEs9/iKYjJcUOOd3Y+roGowiR2ewSqn4OcsFLyS QqvMoOtBCOasiWF7sy+bSugWWJjPhsk0QBAdFofi25fIGvfj/bo3SBiCeWHAzhEV4Yts momw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0z5HbMzk+TNHcYVHCO/5rmn/u7ficHQ0wbbFTmo5UzU=; b=oIp21OYUy7m/RZGxm6WwoOkPzrslHYV1GHkRI9L5Ztq0zEVBOdzmWhXTnw4r2I9Hq9 C7aQNAEA+miMfbPM02Wd0Mj9k9NNjqIzbq2Rm7wTvsR5X9R4xQMO3qQzAMxNEolVv7KD 0HJYsqSmXKuqYiANdWJveuT9j977BC3Nmwn2ftPpGKYYyf42RzkzWu0eo+DeGG3q4vH0 6ejaF6i6GbJ3tnwCoDCnGil870FSb4p4W25BMBRgepzrS6XIodVjrqzpar1hDVCRCT80 DJB0oxPrDN1NB0+X7U2QASBw9to3/ERCQLSboFXrbJtqGVkJ0xdcYxvC8750hzCQWGwN pLQw== X-Gm-Message-State: APjAAAXdeo1eCkUKJ5U+waZwaLAf13/E/5gSkOfoGFKTT/gKAKnGqt1L US7ua/UUbTHpf1+5h5g9u4YiTA== X-Google-Smtp-Source: APXvYqxO7Pu7cyayLc2eUuHye7UyvHfBFgn42OETbQ3/0lzN915uNwmMT3yv7kbtcWLsGn4LaKpKig== X-Received: by 2002:a37:6290:: with SMTP id w138mr6884162qkb.139.1562953526125; Fri, 12 Jul 2019 10:45:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id w24sm3091129qtb.35.2019.07.12.10.45.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Jul 2019 10:45:25 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hlzbp-0003rz-7O; Fri, 12 Jul 2019 14:45:25 -0300 Date: Fri, 12 Jul 2019 14:45:25 -0300 From: Jason Gunthorpe To: Bernard Metzler Cc: Arnd Bergmann , Doug Ledford , Peter Zijlstra , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64 Message-ID: <20190712174525.GM27512@ziepe.ca> References: <20190712153243.GI27512@ziepe.ca> <20190712144257.GE27512@ziepe.ca> <20190712135339.GC27512@ziepe.ca> <20190712120328.GB27512@ziepe.ca> <20190712085212.3901785-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 12, 2019 at 05:40:43PM +0000, Bernard Metzler wrote: > It is because there are two levels a CQ can be armed: > > #include > > int ibv_req_notify_cq(struct ibv_cq *cq, int solicited_only); > > If we kick the CQ handler, we have to clear the whole > thing. The user later again decides how he wants to get it > re-armed...SOLICITED completions only, or ALL signaled. Arrange it so only one of the two bits is ever set and do two test-and-set bits when a SOLICITED CQE comes in? Jason