From: Jiri Olsa <jolsa@redhat.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [RFC] Fix python feature detection
Date: Sun, 14 Jul 2019 17:40:06 +0200 [thread overview]
Message-ID: <20190714154006.GB16802@krava> (raw)
In-Reply-To: <20190707144417.237913-1-joel@joelfernandes.org>
On Sun, Jul 07, 2019 at 10:44:17AM -0400, Joel Fernandes (Google) wrote:
> I am having a hard time building BPF samples by doing a make in
> samples/bpf. While I am debugging that, I ran into the Python issue.
> Even though the system has libpython2.7-dev:
>
> If I just do a 'make' inside tools/build/feature/ I get:
> Python.h: No such file or directory
because you don't have FLAGS_PYTHON_EMBED set?
>
> This led me to this patch which fixes Python feature detection for me.
> I am not sure if it is the right fix for Python since it is hardcoded
> for Python version 2, but I thought it could be useful.
we detect python in tools/perf/Makefile.config and
set FLAGS_PYTHON_EMBED properly
it's supposed to be set by a project using tools/build
for feature detection.. what are you building? AFAICS
samples/bpf do not use tools/build
jirka
>
> My system is a Debian buster release.
>
> Cc: acme@kernel.org
> Cc: jolsa@redhat.com
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
> tools/build/feature/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
> index 4b8244ee65ce..cde44cb38a5e 100644
> --- a/tools/build/feature/Makefile
> +++ b/tools/build/feature/Makefile
> @@ -83,7 +83,7 @@ __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(
> ###############################
>
> $(OUTPUT)test-all.bin:
> - $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma
> + $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -laudit -I/usr/include/slang -lslang $(shell $(PKG_CONFIG) --libs --cflags gtk+-2.0 2>/dev/null) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma
>
> $(OUTPUT)test-hello.bin:
> $(BUILD)
> @@ -205,7 +205,7 @@ $(OUTPUT)test-libperl.bin:
> $(BUILD) $(FLAGS_PERL_EMBED)
>
> $(OUTPUT)test-libpython.bin:
> - $(BUILD) $(FLAGS_PYTHON_EMBED)
> + $(BUILD) $(shell $(PKG_CONFIG) --libs --cflags python2 2>/dev/null) $(FLAGS_PYTHON_EMBED)
>
> $(OUTPUT)test-libpython-version.bin:
> $(BUILD)
> --
> 2.22.0.410.gd8fdbe21b5-goog
>
next prev parent reply other threads:[~2019-07-14 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 14:44 Joel Fernandes (Google)
2019-07-14 15:40 ` Jiri Olsa [this message]
2019-07-14 17:57 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714154006.GB16802@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=joel@joelfernandes.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome