From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED735C76191 for ; Mon, 15 Jul 2019 09:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4E432081C for ; Mon, 15 Jul 2019 09:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729697AbfGOJpv (ORCPT ); Mon, 15 Jul 2019 05:45:51 -0400 Received: from mga17.intel.com ([192.55.52.151]:12295 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729487AbfGOJpu (ORCPT ); Mon, 15 Jul 2019 05:45:50 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 02:45:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,493,1557212400"; d="scan'208";a="190510098" Received: from pertsuli-mobl.ger.corp.intel.com (HELO localhost) ([10.252.36.224]) by fmsmga004.fm.intel.com with ESMTP; 15 Jul 2019 02:45:42 -0700 Date: Mon, 15 Jul 2019 12:45:41 +0300 From: Jarkko Sakkinen To: Tomer Maimon Cc: Oshri Alkobi , Alexander Steffen , Rob Herring , Mark Rutland , peterhuewe@gmx.de, jgg@ziepe.ca, Arnd Bergmann , Greg KH , IS20 Oshri Alkoby , devicetree , AP MS30 Linux Kernel community , linux-integrity@vger.kernel.org, gcwilson@us.ibm.com, kgoldman@us.ibm.com, nayna@linux.vnet.ibm.com, IS30 Dan Morav , eyal.cohen@nuvoton.com Subject: Re: [PATCH v2 0/2] char: tpm: add new driver for tpm i2c ptp Message-ID: <20190715094541.zjqxainggjuvjxd2@linux.intel.com> References: <20190628151327.206818-1-oshrialkoby85@gmail.com> <8e6ca8796f229c5dc94355437351d7af323f0c56.camel@linux.intel.com> <79e8bfd2-2ed1-cf48-499c-5122229beb2e@infineon.com> <45603af2fc8374a90ef9e81a67083395cc9c7190.camel@linux.intel.com> <6e7ff1b958d84f6e8e585fd3273ef295@NTILML02.nuvoton.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 15, 2019 at 11:08:47AM +0300, Tomer Maimon wrote: > Thanks for your feedback and sorry for the late response. > > Due to the amount of work required to handle this technical feedback and > project constraints we need to put this task on hold for the near future. > > In the meantime, anyone from the community is welcome to take over this > code and handle the re-design for the benefit of the entire TPM community. Ok, so there is already driver for this called tpm_tis_core. So you go and create a new module, whose name given the framework of things that we already have deployed, is destined to be tpm_tis_i2c. Then you roughly implement a new physical layer by using a callback interface provided to you by tpm_tis_core. The so called re-design was already addressed by Alexander [1]. How hard can it be seriously? [1] https://lkml.org/lkml/2019/7/4/331 /Jarkko