From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC2FC7618F for ; Mon, 15 Jul 2019 14:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3587E2067C for ; Mon, 15 Jul 2019 14:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202123; bh=a+HfDJiSfl1oFWBjdFBODf5YivhjMmBbKIqceSP04Uw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iUtBrdfPA+M2yfI54lXi5JkTuyD03Flg7Jyvh6J5t3C5A9wANVFoDE5mtXCmb9OA0 q1H+EzI7FHZK/eMuRT17NiedCCzmrROiFTaY7BTZm0MaUrpFkf9oQCN3V5pYTp20Dq pKG5Q4uSSoVjNVnA71M+FWTqRidzidbcpizJ5XnY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404595AbfGOOsl (ORCPT ); Mon, 15 Jul 2019 10:48:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404336AbfGOOsh (ORCPT ); Mon, 15 Jul 2019 10:48:37 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00BFA21537; Mon, 15 Jul 2019 14:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563202117; bh=a+HfDJiSfl1oFWBjdFBODf5YivhjMmBbKIqceSP04Uw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=akMI+7dnCKx6TQIir1z/H0uTwTXgff1tQ+QIJUm+abDEAFe18C1QdRhdoE2tU+ChA oZy3J8h2rbdo5axyzRHBnVVkDncpV6EMj8LZeEb3kM8F+VwBJuSbvHgbb7H4CjeNMa HhwsnLH+p48AknJIavkLMdwih/c4IyG1mUsiiYnw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tomas Bortoli , syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com, Marcel Holtmann , Sasha Levin , linux-bluetooth@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 50/53] Bluetooth: hci_bcsp: Fix memory leak in rx_skb Date: Mon, 15 Jul 2019 10:45:32 -0400 Message-Id: <20190715144535.11636-50-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715144535.11636-1-sashal@kernel.org> References: <20190715144535.11636-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomas Bortoli [ Upstream commit 4ce9146e0370fcd573f0372d9b4e5a211112567c ] Syzkaller found that it is possible to provoke a memory leak by never freeing rx_skb in struct bcsp_struct. Fix by freeing in bcsp_close() Signed-off-by: Tomas Bortoli Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_bcsp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index d0b615a932d1..9833b53a8b50 100644 --- a/drivers/bluetooth/hci_bcsp.c +++ b/drivers/bluetooth/hci_bcsp.c @@ -729,6 +729,11 @@ static int bcsp_close(struct hci_uart *hu) skb_queue_purge(&bcsp->rel); skb_queue_purge(&bcsp->unrel); + if (bcsp->rx_skb) { + kfree_skb(bcsp->rx_skb); + bcsp->rx_skb = NULL; + } + kfree(bcsp); return 0; } -- 2.20.1