From: Daniel Vetter <daniel@ffwll.ch>
To: Qian Cai <cai@lca.pw>
Cc: emil.l.velikov@gmail.com, maarten.lankhorst@linux.intel.com,
maxime.ripard@bootlin.com, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu/drm: fix a few kernel-doc "/**" mark warnings
Date: Tue, 16 Jul 2019 11:24:53 +0200 [thread overview]
Message-ID: <20190716092453.GA15868@phenom.ffwll.local> (raw)
In-Reply-To: <1563198173-7317-1-git-send-email-cai@lca.pw>
On Mon, Jul 15, 2019 at 09:42:53AM -0400, Qian Cai wrote:
> The opening comment mark "/**" is reserved for kernel-doc comments, so
> it will generate warnings for comments that are not kernel-doc with
> "make W=1". For example,
>
> drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file
> drm_memory.c
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Applied to drm-misc-next for 5.4.
-Daniel
> ---
> drivers/gpu/drm/drm_agpsupport.c | 2 +-
> drivers/gpu/drm/drm_dma.c | 2 +-
> drivers/gpu/drm/drm_legacy_misc.c | 2 +-
> drivers/gpu/drm/drm_lock.c | 2 +-
> drivers/gpu/drm/drm_memory.c | 2 +-
> drivers/gpu/drm/drm_scatter.c | 2 +-
> drivers/gpu/drm/drm_vm.c | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c
> index 40fba1c04dfc..ef549c95b0b9 100644
> --- a/drivers/gpu/drm/drm_agpsupport.c
> +++ b/drivers/gpu/drm/drm_agpsupport.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_agpsupport.c
> * DRM support for AGP/GART backend
> *
> diff --git a/drivers/gpu/drm/drm_dma.c b/drivers/gpu/drm/drm_dma.c
> index 3f83e2ca80ad..cbfaa2eaab00 100644
> --- a/drivers/gpu/drm/drm_dma.c
> +++ b/drivers/gpu/drm/drm_dma.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_dma.c
> * DMA IOCTL and function support
> *
> diff --git a/drivers/gpu/drm/drm_legacy_misc.c b/drivers/gpu/drm/drm_legacy_misc.c
> index 2fe786839ca8..745eb9939414 100644
> --- a/drivers/gpu/drm/drm_legacy_misc.c
> +++ b/drivers/gpu/drm/drm_legacy_misc.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_legacy_misc.c
> * Misc legacy support functions.
> *
> diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c
> index b70058e77a28..2610bff3d539 100644
> --- a/drivers/gpu/drm/drm_lock.c
> +++ b/drivers/gpu/drm/drm_lock.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_lock.c
> * IOCTLs for locking
> *
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 132fef8ff1b6..d92f24c308a1 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_memory.c
> * Memory management wrappers for DRM
> *
> diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm/drm_scatter.c
> index bb829a115fc6..b6d863699d0f 100644
> --- a/drivers/gpu/drm/drm_scatter.c
> +++ b/drivers/gpu/drm/drm_scatter.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_scatter.c
> * IOCTLs to manage scatter/gather memory
> *
> diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c
> index 10cf83d569e1..6c74c68f192a 100644
> --- a/drivers/gpu/drm/drm_vm.c
> +++ b/drivers/gpu/drm/drm_vm.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
> * \file drm_vm.c
> * Memory mapping for DRM
> *
> --
> 1.8.3.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2019-07-16 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 13:42 Qian Cai
2019-07-16 9:24 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716092453.GA15868@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=cai@lca.pw \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome