From: Keerthy <j-keerthy@ti.com>
To: <jsarha@ti.com>, <tomi.valkeinen@ti.com>
Cc: <j-keerthy@ti.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<dri-devel@lists.freedesktop.org>, <t-kristo@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough
Date: Wed, 17 Jul 2019 10:39:46 +0530 [thread overview]
Message-ID: <20190717050946.18488-1-j-keerthy@ti.com> (raw)
Fix the below build warning/Error
drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
through [-Werror=implicit-fallthrough=]
reg |= LCDC_V2_TFT_24BPP_UNPACK;
~~~~^~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
case DRM_FORMAT_BGR888:
^~~~
cc1: all warnings being treated as errors
make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
make[4]: *** Waiting for unfinished jobs....
Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 650d162e374b..c95b0652c6ab 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -382,7 +382,8 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
case DRM_FORMAT_XBGR8888:
case DRM_FORMAT_XRGB8888:
reg |= LCDC_V2_TFT_24BPP_UNPACK;
- /* fallthrough */
+ reg |= LCDC_V2_TFT_24BPP_MODE;
+ break;
case DRM_FORMAT_BGR888:
case DRM_FORMAT_RGB888:
reg |= LCDC_V2_TFT_24BPP_MODE;
--
2.17.1
next reply other threads:[~2019-07-17 5:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 5:09 Keerthy [this message]
2019-07-30 6:28 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717050946.18488-1-j-keerthy@ti.com \
--to=j-keerthy@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®