From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F1AC76191 for ; Thu, 18 Jul 2019 08:09:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECE872173B for ; Thu, 18 Jul 2019 08:09:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Z7bNK0nf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389282AbfGRIJO (ORCPT ); Thu, 18 Jul 2019 04:09:14 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36829 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfGRIJN (ORCPT ); Thu, 18 Jul 2019 04:09:13 -0400 Received: by mail-ed1-f68.google.com with SMTP id k21so29375023edq.3 for ; Thu, 18 Jul 2019 01:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+Iyfr5/1NYNdQhpDWPT06wuP/cAAoXegst7lt2IsF58=; b=Z7bNK0nfFW0N6BAI/rd5EED657okw9jUljgqrouABquv5zutt1fVG9cnzovdPvciis KmFVJJy3QcvbNE2hG6hzs11SjCaCGvNXExkjBAoy7FPPfdiQgzM2w8/Q6zsSmyUaMgdt r+fACRtZtYBPe+sS/se1+IEvfwhP/fSaBENKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+Iyfr5/1NYNdQhpDWPT06wuP/cAAoXegst7lt2IsF58=; b=plkf3uHoO2vKekefebX8ZLqJQexX3/BAHgOTwb+7bCGcnwKmhMaIomtAxRvpjfR7+y yQNpvmzsJTLnIlAg8/yHu5NwRiKIzyE5QI4QNU5qV/0BXkQfcd90UU8dJufSClbij7g8 g55GpzAeZBqyv0pNIfZBhuiipb3swaXLCYHAo9+ar/D490FJPhgFr+sbSS62nCMr1HDo fQbqxw/AuRZpenQR5g4CnTGAGozuMdHkqRMvchrEXQJ/DHlJ+yRycK9ZhZeLqmN2vwqw u5O81Z9JdqZ4cC3rQdwiXrMu+aDwawHtFbbbdFkocaOUk/6lYfC0Id/MPEwqpOT7EU7j obmA== X-Gm-Message-State: APjAAAWB5401H1uPvhPM9FR/O+qOWutH6LS0xvgvbpdhk2S7L8MiPM7A SnVVdIa4CgGD/HXhNBgDrQ4= X-Google-Smtp-Source: APXvYqykBiX6Jo5Tfwh9csgIjcDSqs9NfSDZzAEw+X4to7YWwbULxI67P9uCx6KZm68g1spWwShXGQ== X-Received: by 2002:a17:906:6582:: with SMTP id x2mr12620386ejn.2.1563437352239; Thu, 18 Jul 2019 01:09:12 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id l38sm7608440eda.1.2019.07.18.01.09.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 01:09:11 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Cc: Daniel Vetter , Jens Remus , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman , Nicolas Pitre , Martin Hostettler , Adam Borowski , Mikulas Patocka , Daniel Vetter , Sam Ravnborg Subject: [PATCH] vt: Grab console_lock around con_is_bound in show_bind Date: Thu, 18 Jul 2019 10:09:03 +0200 Message-Id: <20190718080903.22622-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Not really harmful not to, but also not harm in grabbing the lock. And this shuts up a new WARNING I introduced in commit ddde3c18b700 ("vt: More locking checks"). Reported-by: Jens Remus Cc: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Cc: linux-s390@vger.kernel.org Cc: Greg Kroah-Hartman Cc: Nicolas Pitre Cc: Martin Hostettler Cc: Adam Borowski Cc: Mikulas Patocka Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Sam Ravnborg --- drivers/tty/vt/vt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index ec92f36ab5c4..34aa39d1aed9 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -3771,7 +3771,11 @@ static ssize_t show_bind(struct device *dev, struct device_attribute *attr, char *buf) { struct con_driver *con = dev_get_drvdata(dev); - int bind = con_is_bound(con->con); + int bind; + + console_lock(); + bind = con_is_bound(con->con); + console_unlock(); return snprintf(buf, PAGE_SIZE, "%i\n", bind); } -- 2.20.1