From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17F1C76191 for ; Thu, 18 Jul 2019 14:03:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3E0E21019 for ; Thu, 18 Jul 2019 14:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403795AbfGRODX (ORCPT ); Thu, 18 Jul 2019 10:03:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6312 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfGRODX (ORCPT ); Thu, 18 Jul 2019 10:03:23 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F631C024AF4; Thu, 18 Jul 2019 14:03:23 +0000 (UTC) Received: from treble (ovpn-122-211.rdu2.redhat.com [10.10.122.211]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1ABF160F94; Thu, 18 Jul 2019 14:03:17 +0000 (UTC) Date: Thu, 18 Jul 2019 09:03:14 -0500 From: Josh Poimboeuf To: Sean Christopherson Cc: Paolo Bonzini , x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Nick Desaulniers , Arnd Bergmann , Jann Horn , Randy Dunlap , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v2 04/22] x86/kvm: Don't call kvm_spurious_fault() from .fixup Message-ID: <20190718140314.24d6ygm7khvcno6m@treble> References: <64a9b64d127e87b6920a97afde8e96ea76f6524e.1563413318.git.jpoimboe@redhat.com> <65bbf58d-f88b-c7d6-523b-6e35f4972bf2@redhat.com> <20190718131654.GE28096@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190718131654.GE28096@linux.intel.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 18 Jul 2019 14:03:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 06:16:54AM -0700, Sean Christopherson wrote: > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > > index 0cc5b611a113..8282b8d41209 100644 > > > --- a/arch/x86/include/asm/kvm_host.h > > > +++ b/arch/x86/include/asm/kvm_host.h > > > @@ -1496,25 +1496,29 @@ enum { > > > #define kvm_arch_vcpu_memslots_id(vcpu) ((vcpu)->arch.hflags & HF_SMM_MASK ? 1 : 0) > > > #define kvm_memslots_for_spte_role(kvm, role) __kvm_memslots(kvm, (role).smm) > > > > > > +asmlinkage void __noreturn kvm_spurious_fault(void); > > With __noreturn added, can the entry in __dead_end_function() in > tools/objtool/check.c be removed? No, that's actually still needed because objtool can't see the __noreturn annotation. So it still needs to know that the "call kvm_spurious_fault" doesn't return. -- Josh