mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org,
	Suren Baghdasaryan <surenb@google.com>,
	kernel-team@android.com, Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christian Brauner <christian@brauner.io>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH RFC v1] pidfd: fix a race in setting exit_state for pidfd polling
Date: Thu, 18 Jul 2019 17:00:58 +0200	[thread overview]
Message-ID: <20190718150057.GB13355@redhat.com> (raw)
In-Reply-To: <20190717172100.261204-1-joel@joelfernandes.org>

On 07/17, Joel Fernandes (Google) wrote:
>
> exit_notify
>   do_notify_parent
>     do_notify_pidfd
>   tsk->exit_state = EXIT_DEAD

OOPS. Somehow I thought it sets exit_state before do_notify_parent(),
I didn't even bother to verify this when I reviewed pidfd_poll()...

Sorry, can't read the patch today, will do tomorrow.

Oleg.


  parent reply	other threads:[~2019-07-18 15:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 17:21 Joel Fernandes (Google)
2019-07-17 17:55 ` Christian Brauner
2019-07-17 18:09   ` Suren Baghdasaryan
2019-07-17 20:47     ` Joel Fernandes
2019-07-18 10:09       ` Christian Brauner
2019-07-17 20:51   ` Joel Fernandes
2019-07-18 10:17 ` Christian Brauner
2019-07-18 16:05   ` Suren Baghdasaryan
2019-07-18 15:00 ` Oleg Nesterov [this message]
2019-07-19 16:14 ` Oleg Nesterov
2019-07-19 16:27   ` Christian Brauner
2019-07-19 16:33     ` Suren Baghdasaryan
2019-07-19 16:51     ` Joel Fernandes
2019-07-19 16:53       ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190718150057.GB13355@redhat.com \
    --to=oleg@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=christian@brauner.io \
    --cc=ebiederm@xmission.com \
    --cc=joel@joelfernandes.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome