From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C6EC76196 for ; Thu, 18 Jul 2019 19:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9A97208C0 for ; Thu, 18 Jul 2019 19:49:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="S/4klFkD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391731AbfGRTt2 (ORCPT ); Thu, 18 Jul 2019 15:49:28 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44621 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390915AbfGRTt2 (ORCPT ); Thu, 18 Jul 2019 15:49:28 -0400 Received: by mail-qt1-f194.google.com with SMTP id 44so933286qtg.11 for ; Thu, 18 Jul 2019 12:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LqBcHSVnlAllZiCdAIfktp/f17HTD3kFXRWdIGauFW4=; b=S/4klFkD+731bYW7+qq/rIq/lS9np6FQhfN5DWdVFYUYB7BxJOsTGOSQyQrZvjtWwO awqzevSWhKvdOp40Z2Idd8B6KZwDjCoVdoQNqnTiqSAQX/SK2903jkOO/WVGzN7krgJP mWHjt422KGWNS5Kb2YArQyxV/sP2mvtsSrfeFbVq3qSU8Vh4F7lXG0hbopEih6s5jaFs N6XJF8xIzqweGVIIv3bPfP1XgrO0luP7rBBFh8OkXdXA/NvqBCFhtn5lYLwMzH9cwOgP roQAgl8Z0XViFrnZQW8IjdtdVYUg+Tn7Ra2vvUMJpfa2aIbS01OSnXDDnxSdxoeS/wxG 41IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LqBcHSVnlAllZiCdAIfktp/f17HTD3kFXRWdIGauFW4=; b=q56OZcroeJVkORhJlpar/2X2tlTST2D5418oKXfDEfUeMwgKNozEsIzAy0ZuLsQu+e 1yDAWYutUGKNkJyauYWhpD7vK2dsdMNdh7zyNkLKu887UVMCUu8Em+lI32468iDCiuWx vUGGJgXbvMyu82/XIjT2PG3/GTWprHMATvb6ftUtfQrxu98gHXS7Kkvh91CuEsCjTZ2d CGXT2FenzQBxNmNYQR21s7bqH7E5r/D5Tf6bt3l2XNQoTMuJSlTBa+6PE9O87/0Mkd45 HVRoR8RLNLrSwHqpAa8f2gXsLUrgJShaCe+erTYes5OlGyaZ9ggw7tqcDLRUxvzxiTBv r6gA== X-Gm-Message-State: APjAAAU0ESCGyGYnWI8+VSEYZuwnplrEb/UsSodBUcYxfK+1y5t1+ZoS +WTVw2fumeD0irX5Xg0CkbVcJw== X-Google-Smtp-Source: APXvYqxLJQTINuoj/Sa55WUDeFWqt2YGpt7FUzZy5ZTPTJBzY1xxa9K4nQKtYnoZgn77M3jRzjsH7w== X-Received: by 2002:a0c:ecc9:: with SMTP id o9mr34822037qvq.100.1563479367148; Thu, 18 Jul 2019 12:49:27 -0700 (PDT) Received: from localhost.localdomain (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id i62sm13548544qke.52.2019.07.18.12.49.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Jul 2019 12:49:26 -0700 (PDT) From: Qian Cai To: rafael.j.wysocki@intel.com Cc: robert.moore@intel.com, erik.schmauss@intel.com, jkim@FreeBSD.org, lenb@kernel.org, ndesaulniers@google.com, linux-acpi@vger.kernel.org, devel@acpica.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH v2] acpica: fix -Wnull-pointer-arithmetic warnings Date: Thu, 18 Jul 2019 15:48:46 -0400 Message-Id: <20190718194846.1880-1-cai@lca.pw> X-Mailer: git-send-email 2.20.1 (Apple Git-117) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clang generate quite a few of those warnings. drivers/acpi/scan.c:759:28: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic] status = acpi_get_handle(ACPI_ROOT_OBJECT, obj->string.pointer, ^~~~~~~~~~~~~~~~ ./include/acpi/actypes.h:458:56: note: expanded from macro 'ACPI_ROOT_OBJECT' #define ACPI_ROOT_OBJECT ((acpi_handle) ACPI_TO_POINTER (ACPI_MAX_PTR)) ^~~~~~~~~~~~~~~ ./include/acpi/actypes.h:509:41: note: expanded from macro 'ACPI_TO_POINTER' #define ACPI_TO_POINTER(i) ACPI_ADD_PTR (void, (void *) 0, (acpi_size) (i)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./include/acpi/actypes.h:503:84: note: expanded from macro 'ACPI_ADD_PTR' #define ACPI_ADD_PTR(t, a, b) ACPI_CAST_PTR (t, (ACPI_CAST_PTR (u8, (a)) + (acpi_size)(b))) ^~~~~~~~~~~~~~~~~ ./include/acpi/actypes.h:501:66: note: expanded from macro 'ACPI_CAST_PTR' #define ACPI_CAST_PTR(t, p) ((t *) (acpi_uintptr_t) (p)) ^ This is because pointer arithmetic on a pointer not pointing to an array is an undefined behavior (C11 6.5.6, constraint 8). Fix it by just casting the corresponding pointers using ACPI_CAST_PTR() and skip the arithmetic. Also, fix a checkpatch warning together. ERROR: Macros with complex values should be enclosed in parentheses #45: FILE: include/acpi/actypes.h:509: +#define ACPI_TO_POINTER(i) ACPI_CAST_PTR (void, i) Signed-off-by: Qian Cai --- v2: Use ACPI_CAST_PTR() in ACPI_TO_POINTER() directly without arithmetic. include/acpi/actypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h index ad6892a24015..163181e2d884 100644 --- a/include/acpi/actypes.h +++ b/include/acpi/actypes.h @@ -506,7 +506,7 @@ typedef u64 acpi_integer; /* Pointer/Integer type conversions */ -#define ACPI_TO_POINTER(i) ACPI_ADD_PTR (void, (void *) 0, (acpi_size) (i)) +#define ACPI_TO_POINTER(i) (ACPI_CAST_PTR (void, i)) #define ACPI_TO_INTEGER(p) ACPI_PTR_DIFF (p, (void *) 0) #define ACPI_OFFSET(d, f) ACPI_PTR_DIFF (&(((d *) 0)->f), (void *) 0) #define ACPI_PHYSADDR_TO_PTR(i) ACPI_TO_POINTER(i) -- 2.20.1 (Apple Git-117)