From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E15C76196 for ; Sat, 20 Jul 2019 06:17:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2109421874 for ; Sat, 20 Jul 2019 06:17:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rtU8y3cs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbfGTGRD (ORCPT ); Sat, 20 Jul 2019 02:17:03 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:34473 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726271AbfGTGRC (ORCPT ); Sat, 20 Jul 2019 02:17:02 -0400 Received: by mail-pf1-f201.google.com with SMTP id i2so19997435pfe.1 for ; Fri, 19 Jul 2019 23:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=4Ja1natgGd5dku0ofnbI0sPWJ6JdTAtBQv7GM8XtXMY=; b=rtU8y3csdMcyicCTS7LbBWVgV0NtGKQO0Ju1Fsm6TfrevXjVIYuL2ASm3am/c4mvcO QfX77ltDH6mZfYoBiuAWkyCNRumhFnYlFl2+3jKf9WxEho+YBshkofLHy1tr6Sjx2kx9 KjLaSwf9IVIvW2M3/LEwSNVx9HGMpToSsv95ddwUm/Z//iQZcqMW4Jf9E+n5TYrBoBUx M3uy1I0t2Hqs5c5eGBGSMKKG5O4XzDmQJWaPD2XEa+0uI97nZktxdKYstr403p/VqqUb EVN+aCEyP30G8BCdnql5JQZTTuMr/tlLrsFI0Ie/1SyCM7HbQbnNNPZX/whglUmQtNn4 Hs+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=4Ja1natgGd5dku0ofnbI0sPWJ6JdTAtBQv7GM8XtXMY=; b=pUiNHzeHwSomfx/Dbm/tuh5wABfeuORnXy52O0n9xS1D2dw+vINK6L75iJ3HmbOwxn oUYudilhy4zmfDeKqIM1SSUxB+158Sac9CMf0zACYrGEXGnKxmtYRGT4hDpg//fUH4Pn FWLcW0lnPkBsq6jwGzAReJfU+tITckFdVoSqKHmXptWGSRStDqX+yYj3QCsrRsJvHV5r 8z08B8QAH5yyI2XQl6J4/UD6gRRXQTK5F6gdbvXFH/p9uhKP5NTzlJcD/HZlGatBhOVN bwNKqKTbkob/OK2by/gR0Ne2jQk6+sFt04OGYSM409v2xZO6wYRMqPLKbsCgXollnSf0 L/Xg== X-Gm-Message-State: APjAAAUB/U2tWzWqOTCJxsWp4+3TEvOYC8z7qIOJDI/Ftrd5ueZkttM9 E3DsLqlF56xcZO1Q9LLutBq19TV1UGk/2Ac= X-Google-Smtp-Source: APXvYqxeOr0l4EvpBx097OmKy1jqNDAm+go7gqFymWSI/xHYbMsf1F89iZUPCoXQUxptfVBdaw7qSEyfnYXdBHI= X-Received: by 2002:a63:c23:: with SMTP id b35mr25073026pgl.265.1563603421227; Fri, 19 Jul 2019 23:17:01 -0700 (PDT) Date: Fri, 19 Jul 2019 23:16:41 -0700 In-Reply-To: <20190720061647.234852-1-saravanak@google.com> Message-Id: <20190720061647.234852-3-saravanak@google.com> Mime-Version: 1.0 References: <20190720061647.234852-1-saravanak@google.com> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog Subject: [PATCH v6 2/7] driver core: Add edit_links() callback for drivers From: Saravana Kannan To: Rob Herring , Mark Rutland , Greg Kroah-Hartman , "Rafael J. Wysocki" , Frank Rowand Cc: Saravana Kannan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Collins , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver core/bus adding supplier-consumer dependencies by default enables functional dependencies to be tracked correctly even when the consumer devices haven't had their drivers registered or loaded (if they are modules). However, when the bus incorrectly adds dependencies that it shouldn't have added, the devices might never probe. For example, if device-C is a consumer of device-S and they have phandles to each other in DT, the following could happen: 1. Device-S get added first. 2. The bus add_links() callback will (incorrectly) try to link it as a consumer of device-C. 3. Since device-C isn't present, device-S will be put in "waiting-for-supplier" list. 4. Device-C gets added next. 5. All devices in "waiting-for-supplier" list are retried for linking. 6. Device-S gets linked as consumer to Device-C. 7. The bus add_links() callback will (correctly) try to link it as a consumer of device-S. 8. This isn't allowed because it would create a cyclic device links. Neither devices will get probed since the supplier is marked as dependent on the consumer. And the consumer will never probe because the consumer can't get resources from the supplier. Without this patch, things stay in this broken state. However, with this patch, the execution will continue like this: 9. Device-C's driver is loaded. 10. Device-C's driver removes Device-S as a consumer of Device-C. 11. Device-C's driver adds Device-C as a consumer of Device-S. 12. Device-S probes. 14. Device-C probes. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 24 ++++++++++++++++++++++-- drivers/base/dd.c | 29 +++++++++++++++++++++++++++++ include/linux/device.h | 18 ++++++++++++++++++ 3 files changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 0705926d362f..6eb14093e905 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -422,6 +422,19 @@ static void device_link_wait_for_supplier(struct device *consumer) mutex_unlock(&wfs_lock); } +/** + * device_link_remove_from_wfs - Unmark device as waiting for supplier + * @consumer: Consumer device + * + * Unmark the consumer device as waiting for suppliers to become available. + */ +void device_link_remove_from_wfs(struct device *consumer) +{ + mutex_lock(&wfs_lock); + list_del_init(&consumer->links.needs_suppliers); + mutex_unlock(&wfs_lock); +} + /** * device_link_check_waiting_consumers - Try to unmark waiting consumers * @@ -439,12 +452,19 @@ static void device_link_wait_for_supplier(struct device *consumer) static void device_link_check_waiting_consumers(void) { struct device *dev, *tmp; + int ret; mutex_lock(&wfs_lock); list_for_each_entry_safe(dev, tmp, &wait_for_suppliers, - links.needs_suppliers) - if (!dev->bus->add_links(dev)) + links.needs_suppliers) { + ret = 0; + if (dev->has_edit_links) + ret = driver_edit_links(dev); + else if (dev->bus->add_links) + ret = dev->bus->add_links(dev); + if (!ret) list_del_init(&dev->links.needs_suppliers); + } mutex_unlock(&wfs_lock); } diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 0df9b4461766..842fc7b704f9 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -659,6 +659,12 @@ int driver_probe_device(struct device_driver *drv, struct device *dev) pr_debug("bus: '%s': %s: matched device %s with driver %s\n", drv->bus->name, __func__, dev_name(dev), drv->name); + if (drv->edit_links) { + if (drv->edit_links(dev)) + dev->has_edit_links = true; + else + device_link_remove_from_wfs(dev); + } pm_runtime_get_suppliers(dev); if (dev->parent) pm_runtime_get_sync(dev->parent); @@ -747,6 +753,29 @@ struct device_attach_data { bool have_async; }; +static int __driver_edit_links(struct device_driver *drv, void *data) +{ + struct device *dev = data; + + if (!drv->edit_links) + return 0; + + if (driver_match_device(drv, dev) <= 0) + return 0; + + return drv->edit_links(dev); +} + +int driver_edit_links(struct device *dev) +{ + int ret; + + device_lock(dev); + ret = bus_for_each_drv(dev->bus, NULL, dev, __driver_edit_links); + device_unlock(dev); + return ret; +} + static int __device_attach_driver(struct device_driver *drv, void *_data) { struct device_attach_data *data = _data; diff --git a/include/linux/device.h b/include/linux/device.h index 7f8ae7e5fc6b..a2d509a36ebe 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -254,6 +254,20 @@ enum probe_type { * @probe_type: Type of the probe (synchronous or asynchronous) to use. * @of_match_table: The open firmware table. * @acpi_match_table: The ACPI match table. + * @edit_links: Called to allow a matched driver to edit the device links the + * bus might have added incorrectly. This will be useful to handle + * cases where the bus incorrectly adds functional dependencies + * that aren't true or tries to create cyclic dependencies. But + * doesn't correctly handle functional dependencies that are + * missed by the bus as the supplier's sync_state might get to + * execute before the driver for a missing consumer is loaded and + * gets to edit the device links for the consumer. + * + * This function might be called multiple times after a new device + * is added. The function is expected to create all the device + * links for the new device and return 0 if it was completed + * successfully or return an error if it needs to be reattempted + * in the future. * @probe: Called to query the existence of a specific device, * whether this driver can work with it, and bind the driver * to a specific device. @@ -293,6 +307,7 @@ struct device_driver { const struct of_device_id *of_match_table; const struct acpi_device_id *acpi_match_table; + int (*edit_links)(struct device *dev); int (*probe) (struct device *dev); int (*remove) (struct device *dev); void (*shutdown) (struct device *dev); @@ -1065,6 +1080,7 @@ struct device { bool offline_disabled:1; bool offline:1; bool of_node_reused:1; + bool has_edit_links:1; #if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \ defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \ defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL) @@ -1314,6 +1330,7 @@ extern int __must_check device_attach(struct device *dev); extern int __must_check driver_attach(struct device_driver *drv); extern void device_initial_probe(struct device *dev); extern int __must_check device_reprobe(struct device *dev); +extern int driver_edit_links(struct device *dev); extern bool device_is_bound(struct device *dev); @@ -1404,6 +1421,7 @@ struct device_link *device_link_add(struct device *consumer, struct device *supplier, u32 flags); void device_link_del(struct device_link *link); void device_link_remove(void *consumer, struct device *supplier); +void device_link_remove_from_wfs(struct device *consumer); #ifndef dev_fmt #define dev_fmt(fmt) fmt -- 2.22.0.657.g960e92d24f-goog