From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36233C76188 for ; Mon, 22 Jul 2019 05:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04F63219BE for ; Mon, 22 Jul 2019 05:46:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563774403; bh=w3TBOJJn/HlQ6NPhz6av6SW4eu+NoQprGaG5lCjpSmU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mh0vspgPc28FOEOWYHsePrwOP6Lqqu+eHidTYRJAL6ltM2L4C9WsAKvfFHZOnMdar 09FBC0CmD4JNe6wMCrgJiFSWtG3C08Nq0la6sYHqYEFLRdNPaBwgCkxrETp9jOwIWR zOtrP6iZfK67UENxATBsZRi2jo6IhWtJx4HrYeRk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726888AbfGVFql (ORCPT ); Mon, 22 Jul 2019 01:46:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:39026 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbfGVFql (ORCPT ); Mon, 22 Jul 2019 01:46:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E7EC6AD12; Mon, 22 Jul 2019 05:46:38 +0000 (UTC) Date: Mon, 22 Jul 2019 07:46:37 +0200 From: Michal Hocko To: Linus Torvalds Cc: Andrew Morton , Vlastimil Babka , toshi.kani@hpe.com, rppt@linux.ibm.com, richardw.yang@linux.intel.com, pasha.tatashin@soleen.com, osalvador@suse.de, logang@deltatee.com, jmoyer@redhat.com, Jerome Glisse , Jason Gunthorpe , jane.chu@oracle.com, Christoph Hellwig , David Hildenbrand , Jonathan Corbet , Qian Cai , "Aneesh Kumar K.V" , Dan Williams , Linux List Kernel Mailing , mm-commits@vger.kernel.org Subject: Re: [patch 23/38] mm/sparsemem: introduce struct mem_section_usage Message-ID: <20190722054637.GW30461@dhcp22.suse.cz> References: <20190718225757.ndUBg%akpm@linux-foundation.org> <20190719061313.GI30461@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 19-07-19 09:42:18, Linus Torvalds wrote: > On Thu, Jul 18, 2019 at 11:13 PM Michal Hocko wrote: > > > > Has this been properly reviewed after the last rebase and is this > > actually ready for merging? I have seen some follow up fixes > > http://lkml.kernel.org/r/20190715081549.32577-1-osalvador@suse.de > > and do not see those patches being in the pipe line. Or have they been > > merged? > > It looks to me from the patches that Andrew updated them with > > https://lore.kernel.org/linux-mm/20190715081549.32577-2-osalvador@suse.de/ > > and > > https://lore.kernel.org/linux-mm/20190718120543.GA8500@linux/ > > so it looks good to me. > > But that's just from reading the patches, I might have missed > something and I don't see the history. Thanks for double checking! It's good that follow up fixes didn't fall through cracks. Anyway I have to say that I find merging shortly after a non-trivial rebase as risky and rushed through. I am not really convinced this is so urgent to warrant such a step. I hoped to get to it eventually and give it a deeper review because this is a non trivial stuff. I am sorry but I couldn't have done that yet (busy with other stuff and being OOO for quite some time). -- Michal Hocko SUSE Labs