From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8577EC76188 for ; Mon, 22 Jul 2019 15:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4415521911 for ; Mon, 22 Jul 2019 15:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbfGVPAO (ORCPT ); Mon, 22 Jul 2019 11:00:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:38654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfGVPAN (ORCPT ); Mon, 22 Jul 2019 11:00:13 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 834302190F; Mon, 22 Jul 2019 15:00:12 +0000 (UTC) Date: Mon, 22 Jul 2019 11:00:10 -0400 From: Steven Rostedt To: Catalin Marinas Cc: Mark Rutland , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Masami Hiramatsu Subject: Re: [for-next][PATCH 12/16] kprobes: Initialize kprobes at postcore_initcall Message-ID: <20190722110010.7db27b06@gandalf.local.home> In-Reply-To: <20190722124202.GF60625@arrakis.emea.arm.com> References: <20190526191828.466305460@goodmis.org> <20190526191848.266163206@goodmis.org> <20190702165008.GC34718@lakrids.cambridge.arm.com> <20190703100205.0b58f3bf@gandalf.local.home> <20190703140832.GD48312@arrakis.emea.arm.com> <20190709111520.5f098b22@gandalf.local.home> <20190722124202.GF60625@arrakis.emea.arm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jul 2019 13:42:02 +0100 Catalin Marinas wrote: > > I agree with Masami, that the selftest actually caught a bug here. I > > think the arch code may need to change as the purpose of Masami's > > changes was to enable kprobes earlier in boot. The selftest failing > > means that an early kprobe will fail too. > > I just got back from holiday and catching up with emails. Do I still > need to merge the arm64 fix making the debug initialisation a > core_initcall()? > > Can we actually get kprobes invoked before init_kprobes() has been > called? Bah, I can't remember everything that we discussed. I thought there was some more patches that obsoleted my work around. Everything has been pushed to Linus, can you see if the upstream still has issues for you? Thanks! -- Steve