From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C8CC7618F for ; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68C2B2190D for ; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FfZ6mG6b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731817AbfGVSZF (ORCPT ); Mon, 22 Jul 2019 14:25:05 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:44855 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731757AbfGVSZE (ORCPT ); Mon, 22 Jul 2019 14:25:04 -0400 Received: by mail-pl1-f196.google.com with SMTP id t14so19507823plr.11 for ; Mon, 22 Jul 2019 11:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x8c0DPCRMv9IW9PP1p4HBNy16Fzp3nQIOkgwmBpQwpo=; b=FfZ6mG6bnACwo8lgLXr1zYGkAj7V4iNwkTU4H5ELO+CqHQDbFy8TPLhLV8XtPvILqW TowJOHAi23SCQrrxtT2YTfMTfZT0utOVqKKuvQM9feJUKIT7JNt7M+zJZk8pj3Ja4Z0d xtriekUe46UMlYaBOMlvThIUciUDwEHKz3k6E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x8c0DPCRMv9IW9PP1p4HBNy16Fzp3nQIOkgwmBpQwpo=; b=oEzz8RsEN5mxVxOLA5v/Ib4uoKshAxW+Go0h8bgBTsUSysqaFsMfNRp8Z/KeNsvtLn suXGARK4WV+Vv9ZnYRVv76J6i9SJ3qnRKWt0iCZW0Lwrd/YLN1bKxDG4wwYnc0tyMn6N h7OoORmRXzO0fOmCv2tme6ug2hmNK4j5dQf9s/dyHLBpmbho+HG54X7dGeIwPjP+leMl yU22XfWoZ1DhX/ohSeWuCBiNtENIRfcsmfSH91yKcsCfbgqJ4q0Y8K6h6o4Or27qIB6D B5Z35u1IdS00h+qZXOi8LvV0urnADp3AcdwI9qlCP4DDFPWZ675Xu3R976NHeqtIsYX9 pHJw== X-Gm-Message-State: APjAAAVZ393OOnOTRgZiMd0DaPN/sy6ZRBn8yjPGLkLZIoj7x34m6afg mxyv6Utdoox8lKaoZCTTmk/72Q== X-Google-Smtp-Source: APXvYqwyyl3J3Mb8JWQgZSDuxJTdfEQ/qKsf4Mi5pmNYAuIsVFOtUl3uWg6CUWJmNS9uHBU4AAA4AQ== X-Received: by 2002:a17:902:7448:: with SMTP id e8mr76695940plt.85.1563819903648; Mon, 22 Jul 2019 11:25:03 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:03 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Cc: David Airlie , linux-fbdev@vger.kernel.org, Philipp Zabel , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Laurent Pinchart , Russell King , Daniel Vetter , Douglas Anderson , linux-kernel@vger.kernel.org, Linus Walleij Subject: [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing() Date: Mon, 22 Jul 2019 11:24:35 -0700 Message-Id: <20190722182439.44844-1-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As reported by Sam Ravnborg [1], after commit b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical timing") we now see a pointless error message printed on every boot for many systems. Let's fix that by adjusting who is responsible for printing error messages when of_get_display_timing() is used. Most certainly we can bikeshed the topic about whether this is the right fix or we should instead add logic to panel_simple_probe() to avoid calling of_get_display_timing() in the case where there is no "panel-timing" sub-node. If there is consensus that I should move the fix to panel_simple_probe() I'm happy to spin this series. In that case we probably should _remove_ the extra prints that were already present in the other two callers of of_get_display_timing(). While at it, fix a missing of_node_put() found by code inspection. NOTE: amba-clcd and panel-lvds were only compile-tested. [1] https://lkml.kernel.org/r/20190721093815.GA4375@ravnborg.org Douglas Anderson (4): video: of: display_timing: Add of_node_put() in of_get_display_timing() video: of: display_timing: Don't yell if no timing node is present drm: panel-lvds: Spout an error if of_get_display_timing() gives an error video: amba-clcd: Spout an error if of_get_display_timing() gives an error drivers/gpu/drm/panel/panel-lvds.c | 5 ++++- drivers/video/fbdev/amba-clcd.c | 4 +++- drivers/video/of_display_timing.c | 11 +++++++---- 3 files changed, 14 insertions(+), 6 deletions(-) -- 2.22.0.657.g960e92d24f-goog