From: "George G. Davis" <george_davis@mentor.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: kmem: convert call_site addresses to user friendly symbols
Date: Mon, 22 Jul 2019 17:23:22 -0400 [thread overview]
Message-ID: <20190722212322.GA10300@mam-gdavis-lt> (raw)
In-Reply-To: <20190722094343.1e9a5920@gandalf.local.home>
Hello Steve,
On Mon, Jul 22, 2019 at 09:43:43AM -0400, Steven Rostedt wrote:
>
> Looking at the kbuild report...
>
> On Fri, 19 Jul 2019 22:22:40 -0400
> "George G. Davis" <george_davis@mentor.com> wrote:
>
> > diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
> > index eb57e3037deb..ae18e61fa1c0 100644
> > --- a/include/trace/events/kmem.h
> > +++ b/include/trace/events/kmem.h
> > @@ -35,7 +35,7 @@ DECLARE_EVENT_CLASS(kmem_alloc,
> > __entry->gfp_flags = gfp_flags;
> > ),
> >
> > - TP_printk("call_site=%lx ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
> > + TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
>
> Note, %lx expects an unsigned long, %pS expects a pointer.
>
> > __entry->call_site,
>
> You need to change the above to: (void *)__entry->call_site,
Oops, I should have paid more attention. Fixed.
Thanks!
>
> -- Steve
>
> > __entry->ptr,
> > __entry->bytes_req,
--
Regards,
George
prev parent reply other threads:[~2019-07-22 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 2:22 George G. Davis
2019-07-21 5:26 ` kbuild test robot
2019-07-22 13:43 ` Steven Rostedt
2019-07-22 21:23 ` George G. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722212322.GA10300@mam-gdavis-lt \
--to=george_davis@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®