From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEEF9C7618F for ; Mon, 22 Jul 2019 21:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA2562199C for ; Mon, 22 Jul 2019 21:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831137; bh=4ePKRVOjuk0pdWmx57Jr5AQcVG8sUyMlkiLelXx84UU=; h=In-Reply-To:References:Subject:To:Cc:From:Date:List-ID:From; b=bfY+0ZDkMvWTzyOp5AQnS4uK+E82CJbfX2BbbnDDgR3ARW1+ioccB/hRN8RkczS1K 8P4Ppk4v9tuK45JzCSuq8YMKXJP4fMCEWiVoQj+jGpy2RWGhXZS13dsDeUHAnB2N3q M7S+LfMNfnFqZS5S/LfGXqCiSgr23/l0wKW56+JA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732690AbfGVVcQ (ORCPT ); Mon, 22 Jul 2019 17:32:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:39392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728016AbfGVVcQ (ORCPT ); Mon, 22 Jul 2019 17:32:16 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B79B21900; Mon, 22 Jul 2019 21:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831135; bh=4ePKRVOjuk0pdWmx57Jr5AQcVG8sUyMlkiLelXx84UU=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=Qry+PWBd926llkTs47Y1tV3OpEOjUw9u7ySLBx4LyW+s/RNEWYd+7XCZcWVbnzgvd pRua+Q7cWTp1cp6QJala2Xc5wxa4kurCzy4CCoSK5R4f4nMkd/i0MfbyLiJTYulo0x kikV7uMfILBA+IHveio5Z7NYYXW7seS4wCy+tHGw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190625091002.27567-1-codrin.ciubotariu@microchip.com> References: <20190625091002.27567-1-codrin.ciubotariu@microchip.com> Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 To: Codrin Ciubotariu , alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, nicolas.ferre@microchip.com Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Codrin Ciubotariu From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 14:32:14 -0700 Message-Id: <20190722213215.9B79B21900@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Codrin Ciubotariu (2019-06-25 02:10:02) > In clk_generated_determine_rate(), if the divisor is greater than > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. > If clk_generated_set_rate() will be called later with this wrong > rate, it will return -EINVAL, so the generated clock won't change > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1. >=20 > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor lo= op") > Signed-off-by: Codrin Ciubotariu > Acked-by: Nicolas Ferre > Acked-by: Ludovic Desroches > --- Applied to clk-fixes