From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BEC4C7618F for ; Tue, 23 Jul 2019 02:36:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68D232238C for ; Tue, 23 Jul 2019 02:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563849404; bh=ZjmxKozfFKHGpWIrPVKAeXJWZzSSxjFtmKBfxfrLBb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=m7KohgGb3118ymW341Kb9lr0QudnOvj+vVYuNC7NREa88QzQmtJWfjIxUp7KBZur6 MH2uEhQJ3t035VTP2W5+UdBsxyM8I8+GkRbl/fjZBvTB+2jo/j2fO9zPpsY6TiLOvz V4qSscy6poBK8YEixfRiMaWZx5iPksXBjX0k4eGo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731180AbfGWCgn (ORCPT ); Mon, 22 Jul 2019 22:36:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:39168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfGWCgm (ORCPT ); Mon, 22 Jul 2019 22:36:42 -0400 Received: from localhost (unknown [104.132.0.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C97422389; Tue, 23 Jul 2019 02:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563849401; bh=ZjmxKozfFKHGpWIrPVKAeXJWZzSSxjFtmKBfxfrLBb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tK7agweKzWNK/P2dMO2nsSyz7fTlwYn5cfijN8wssogZixRSSnw6a05/NVP80sroO FNjAwrlLt0VeMCRn/vQQnzI3IW5qP78oNveL7Gvt3DRbH5QStv/mIzxyXfD2QWv/9K MYpc7WWGMZXRbisrgEhxK5q8y8Z9AT18foEQ96NQ= Date: Mon, 22 Jul 2019 19:36:40 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH v2] f2fs: separate NOCoW and pinfile semantics Message-ID: <20190723023640.GC60778@jaegeuk-macbookpro.roam.corp.google.com> References: <20190719073903.9138-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190719073903.9138-1-yuchao0@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19, Chao Yu wrote: > Pinning a file is heavy, because skipping pinned files make GC > running with heavy load or no effect. Pinned file is a part of NOCOW files, so I don't think we can simply drop it for backward compatibility. > > So that this patch propose to separate nocow and pinfile semantics: > - NOCoW flag can only be set on regular file. > - NOCoW file will only trigger IPU at common writeback/flush. > - NOCow file will do OPU during GC. > > For the demand of 1) avoid fragment of file's physical block and > 2) userspace don't care about file's specific physical address, > tagging file as NOCoW will be cheaper than pinned one. > > Signed-off-by: Chao Yu > --- > v2: > - rebase code to fix compile error. > fs/f2fs/data.c | 3 ++- > fs/f2fs/f2fs.h | 1 + > fs/f2fs/file.c | 22 +++++++++++++++++++--- > 3 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index a2a28bb269bf..15fb8954c363 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1884,7 +1884,8 @@ static inline bool check_inplace_update_policy(struct inode *inode, > > bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) > { > - if (f2fs_is_pinned_file(inode)) > + if (f2fs_is_pinned_file(inode) || > + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) > return true; > > /* if this is cold file, we should overwrite to avoid fragmentation */ > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 596ab3e1dd7b..f6c5a3d2e659 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2374,6 +2374,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) > #define F2FS_NOATIME_FL 0x00000080 /* do not update atime */ > #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ > #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ > +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ > #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ > > /* Flags that should be inherited by new inodes from their parent. */ > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 7ca545874060..ae0fec54cac6 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1692,6 +1692,7 @@ static const struct { > { F2FS_NOATIME_FL, FS_NOATIME_FL }, > { F2FS_INDEX_FL, FS_INDEX_FL }, > { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, > + { F2FS_NOCOW_FL, FS_NOCOW_FL }, > { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, > }; > > @@ -1715,7 +1716,8 @@ static const struct { > FS_NODUMP_FL | \ > FS_NOATIME_FL | \ > FS_DIRSYNC_FL | \ > - FS_PROJINHERIT_FL) > + FS_PROJINHERIT_FL | \ > + FS_NOCOW_FL) > > /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ > static inline u32 f2fs_iflags_to_fsflags(u32 iflags) > @@ -1753,8 +1755,6 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) > fsflags |= FS_ENCRYPT_FL; > if (f2fs_has_inline_data(inode) || f2fs_has_inline_dentry(inode)) > fsflags |= FS_INLINE_DATA_FL; > - if (is_inode_flag_set(inode, FI_PIN_FILE)) > - fsflags |= FS_NOCOW_FL; > > fsflags &= F2FS_GETTABLE_FS_FL; > > @@ -1794,6 +1794,22 @@ static int f2fs_ioc_setflags(struct file *filp, unsigned long arg) > if (ret) > goto out; > > + if ((fsflags ^ old_fsflags) & FS_NOCOW_FL) { > + if (!S_ISREG(inode->i_mode)) { > + ret = -EINVAL; > + goto out; > + } > + > + if (f2fs_should_update_outplace(inode, NULL)) { > + ret = -EINVAL; > + goto out; > + } > + > + ret = f2fs_convert_inline_inode(inode); > + if (ret) > + goto out; > + } > + > ret = f2fs_setflags_common(inode, iflags, > f2fs_fsflags_to_iflags(F2FS_SETTABLE_FS_FL)); > out: > -- > 2.18.0.rc1