From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942E7C76194 for ; Tue, 23 Jul 2019 07:06:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6432821911 for ; Tue, 23 Jul 2019 07:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563865606; bh=8DNTNA69E09kfKyYJ0fGnoLZ0kjaSElOrnnWQY719Dw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZlHWLI4Vl9H8g9uOZh+aFA61fAyjwuixa5Me+1KIyc6lfRElCSGSxv+pE3oA2Rsrf rU4vTPj/ksar2vY5IX8vKxLx+n6ax7atTtsnJxzHYIjEw9cQ3V81KdUj/3hU6K8CQJ WCXY2QiABeT3H3uVde6e1Wii7c6VEyhticSM6oqU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388199AbfGWHGp (ORCPT ); Tue, 23 Jul 2019 03:06:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:59780 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725837AbfGWHGo (ORCPT ); Tue, 23 Jul 2019 03:06:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 77322AE91; Tue, 23 Jul 2019 07:06:43 +0000 (UTC) Date: Tue, 23 Jul 2019 09:06:42 +0200 From: Michal Hocko To: KarimAllah Ahmed Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Pavel Tatashin , Oscar Salvador , Mike Rapoport , Baoquan He , Qian Cai , Wei Yang , Logan Gunthorpe Subject: Re: [PATCH] mm: sparse: Skip no-map regions in memblocks_present Message-ID: <20190723070642.GC4552@dhcp22.suse.cz> References: <1562921491-23899-1-git-send-email-karahmed@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562921491-23899-1-git-send-email-karahmed@amazon.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 12-07-19 10:51:31, KarimAllah Ahmed wrote: > Do not mark regions that are marked with nomap to be present, otherwise > these memblock cause unnecessarily allocation of metadata. This begs for much more information. How come nomap regions are in usable memblocks? What if memblock allocator used that memory? In other words, shouldn't nomap (an unusable memory iirc) be in reserved memblocks or removed altogethher? > Cc: Andrew Morton > Cc: Pavel Tatashin > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Mike Rapoport > Cc: Baoquan He > Cc: Qian Cai > Cc: Wei Yang > Cc: Logan Gunthorpe > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: KarimAllah Ahmed > --- > mm/sparse.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/sparse.c b/mm/sparse.c > index fd13166..33810b6 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -256,6 +256,10 @@ void __init memblocks_present(void) > struct memblock_region *reg; > > for_each_memblock(memory, reg) { > + > + if (memblock_is_nomap(reg)) > + continue; > + > memory_present(memblock_get_region_node(reg), > memblock_region_memory_base_pfn(reg), > memblock_region_memory_end_pfn(reg)); > -- > 2.7.4 -- Michal Hocko SUSE Labs